Bugzilla – Attachment 33439 Details for
Bug 12359
hidepatronname doesn't hide on the holds queue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12359: Add HidePatronName functionality to the holds queue
Bug-12359-Add-HidePatronName-functionality-to-the-.patch (text/plain), 2.95 KB, created by
Katrin Fischer
on 2014-11-10 19:28:25 UTC
(
hide
)
Description:
Bug 12359: Add HidePatronName functionality to the holds queue
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-11-10 19:28:25 UTC
Size:
2.95 KB
patch
obsolete
>From e30c892cc08fd1f231a4444a77cda709a0ed270f Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Mon, 10 Nov 2014 20:23:45 +0100 >Subject: [PATCH] Bug 12359: Add HidePatronName functionality to the holds > queue > >This changes the Holds Queue page to not show the patron's name >and phone number, but only the cardnumber, when HidePatronName >is set to 'Don't show' > >This also changes the link to the patron account to use >the borrowernumber instead of the cardnumber, which seems >more consistent. > >Fixes a tiny capitalization error: Only item... > >To test: >- Look at the holds queue page with holds displayed >- Toggle HidePatronName system preference and observe the change >- Make sure the link works correctly >--- > .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index b247706..3ee5e4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -2,6 +2,7 @@ > [% USE ItemTypes %] > [% USE Branches %] > [% USE AuthorisedValues %] >+[% USE Koha %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Circulation › Holds queue</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -83,12 +84,19 @@ $(document).ready(function() { > <td class="hq-enumchron">[% itemsloo.enumchron %]</td> > <td class="hq-barcode"> > [% IF ( itemsloo.item_level_request ) %] >- <em>Only Item:</em> <strong>[% itemsloo.barcode %]</strong> >+ <em>Only item:</em> <strong>[% itemsloo.barcode %]</strong> > [% ELSE %] > <strong>[% itemsloo.barcode %]</strong> <em>or any available</em> > [% END %] > </td> >- <td class="hq-patron"><p><a href="/cgi-bin/koha/circ/circulation.pl?findborrower=[% itemsloo.cardnumber %]#reserves">[% itemsloo.surname %], [% itemsloo.firstname %] ([% itemsloo.cardnumber %])</a></p> <p>[% itemsloo.phone %]</p></td> >+ <td class="hq-patron"> >+ [% IF Koha.Preference('HidePatronName') %] >+ <p><a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% itemsloo.borrowernumber %]#reserves">[% itemsloo.cardnumber %]</a></p> >+ [% ELSE %] >+ <p><a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% itemsloo.borrowernumber %]#reserves">[% itemsloo.surname %], [% itemsloo.firstname %] ([% itemsloo.cardnumber %])</a></p> >+ <p>[% itemsloo.phone %]</p> >+ [% END %] >+ </td> > <td class="hq-sendto">[% Branches.GetName( itemsloo.pickbranch ) %]</td> > <td class="hq-date"><span title="[% itemsloo.reservedate %]">[% itemsloo.reservedate | $KohaDates %]</span></td> > <td class="hq-notes">[% itemsloo.notes %]</td> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12359
:
33439
|
56571
|
56847
|
57637