Bugzilla – Attachment 33458 Details for
Bug 13229
Suggestion date filters have a style problem
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13229 - Suggestion date filters have a style problem
Bug-13229---Suggestion-date-filters-have-a-style-p.patch (text/plain), 6.41 KB, created by
Blou
on 2014-11-11 15:42:28 UTC
(
hide
)
Description:
Bug 13229 - Suggestion date filters have a style problem
Filename:
MIME Type:
Creator:
Blou
Created:
2014-11-11 15:42:28 UTC
Size:
6.41 KB
patch
obsolete
>From 3ba481288375fa72a0dff59c74f80ff0b8031aea Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 11 Nov 2014 08:40:36 -0500 >Subject: [PATCH] Bug 13229 - Suggestion date filters have a style problem > >The suggestion date filters appear to be picking up a style change which >wasn't anticipated for the suggestions page markup. This patch solves >the problem by simplifying and standardizing the markup, including >simplifications to the label structure. > >To test, apply the patch and view the suggestions management page in the >staff client. Expand the "suggestion information" filter section and >confirm that the label/input structure looks correct and works >correctly. > >Signed-off-by: Blou <philippe.blouin@inlibro.com> >--- > .../prog/en/modules/suggestion/suggestion.tt | 48 ++++++++++------------ > 1 file changed, 21 insertions(+), 27 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index c8e25f0..bfe0198 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -708,41 +708,35 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o > <li><label for="suggestedby"> Suggested by:</label><select id="suggestedby" name="suggestedby"><option value="">Any</option> > [% FOREACH suggestedby_loo IN suggestedby_loop %][% IF ( suggestedby_loo.selected ) %]<option value="[% suggestedby_loo.code %]" selected="selected">[% suggestedby_loo.desc %]</option>[% ELSE %]<option value="[% suggestedby_loo.code %]">[% suggestedby_loo.desc %]</option>[% END %][% END %] > </select></li> >- <li><label for="suggesteddate_from"> Suggested on:</label> >- <table class="invis"> >- <tr> >- <td><label for="suggesteddate_from">from:</label></td><td><input type="text" id="suggesteddate_from" name="suggesteddate_from" value="[% suggesteddate_from %]" style="width:76px;" /></td> >- </tr> >- <tr> >- <td><label for="suggesteddate_to">to:</label></td><td><input type="text" id="suggesteddate_to" name="suggesteddate_to" value="[% suggesteddate_to %]" style="width:76px;" /></td> >- </tr> >- </table> >+ <li> >+ <label for="suggesteddate_from">Suggested date from:</label> >+ <input type="text" id="suggesteddate_from" size="10" name="suggesteddate_from" value="[% suggesteddate_from %]" /> >+ </li> >+ <li> >+ <label for="suggesteddate_to">To:</label> >+ <input type="text" id="suggesteddate_to" size="10" name="suggesteddate_to" value="[% suggesteddate_to %]" /> > </li> > <li><label for="managedby"> Managed by:</label><select id="managedby" name="managedby"><option value="">Any</option> > [% FOREACH managedby_loo IN managedby_loop %][% IF ( managedby_loo.selected ) %]<option value="[% managedby_loo.code %]" selected="selected">[% managedby_loo.desc %]</option>[% ELSE %]<option value="[% managedby_loo.code %]">[% managedby_loo.desc %]</option>[% END %][% END %] > </select></li> >- <li><label for="manageddate_from"> Management date:</label> >- <table class="invis"> >- <tr> >- <td><label for="manageddate_from">from:</label></td><td><input type="text" id="manageddate_from" name="manageddate_from" value="[% manageddate_from %]" style="width:76px;" /></td> >- </tr> >- <tr> >- <td><label for="manageddate_to">to:</label></td><td><input type="text" id="manageddate_to" name="manageddate_to" value="[% manageddate_to %]" style="width:76px;" /></td> >- </tr> >- </table> >+ <li> >+ <label for="manageddate_from">Management date from:</label> >+ <input type="text" id="manageddate_from" size="10" name="manageddate_from" value="[% manageddate_from %]" /> >+ </li> >+ <li> >+ <label for="manageddate_to">To:</label> >+ <input type="text" id="manageddate_to" size="10" name="manageddate_to" value="[% manageddate_to %]" /> > </li> > <li><label for="acceptedby"> Accepted by:</label><select id="acceptedby" name="acceptedby"><option value="">Any</option> > [% FOREACH acceptedby_loo IN acceptedby_loop %][% IF ( acceptedby_loo.selected ) %] <option value="[% acceptedby_loo.code %]" selected="selected">[% acceptedby_loo.desc %]</option>[% ELSE %]<option value="[% acceptedby_loo.code %]">[% acceptedby_loo.desc %]</option>[% END %][% END %] > </select></li> >- <li><label for="accepteddate_from"> Accepted on:</label> >- <table class="invis"> >- <tr> >- <td><label for="accepteddate_from">from:</label></td><td><input type="text" id="accepteddate_from" name="accepteddate_from" value="[% accepteddate_from %]" style="width:76px;" /></td> >- </tr> >- <tr> >- <td><label for="accepteddate_to">to:</label></td><td><input type="text" id="accepteddate_to" name="accepteddate_to" value="[% accepteddate_to %]" style="width:76px;" /></td> >- </tr> >- </table> >+ <li> >+ <label for="accepteddate_from">Accepted date from:</label> >+ <input type="text" id="accepteddate_from" size="10" name="accepteddate_from" value="[% accepteddate_from %]" /> >+ </li> >+ <li> >+ <label for="accepteddate_to">To:</label> >+ <input type="text" id="accepteddate_to" size="10" name="accepteddate_to" value="[% accepteddate_to %]" /> > </li> > <li><input type="submit" value="Go" /></li></ol> > </fieldset> >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13229
:
33444
|
33456
|
33458
|
33466