Attachment 33486 Details for Bug 13222 – Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status

[patch] Bug 13222 - Accessors for import_record.status have variable names suggesting overlay_status

Bug-13222---Accessors-for-importrecordstatus-have-.patch (text/plain), 1.80 KB, created by Jonathan Druart on 2014-11-12 14:00:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-11-12 14:00:51 UTC

Size: 1.80 KB

patch

obsolete

>From 3a9c4ea3e4a68f513c0b5f95da989a082efbfc39 Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Fri, 7 Nov 2014 17:07:46 +0200
>Subject: [PATCH] Bug 13222 - Accessors for import_record.status have variable
> names suggesting overlay_status
>
>TODO:: Somebody who knows what these are about could write some documentation about it.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> C4/ImportBatch.pm | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm
>index b8d2560..08304d7 100644
>--- a/C4/ImportBatch.pm
>+++ b/C4/ImportBatch.pm
>@@ -1328,7 +1328,7 @@ sub SetImportRecordOverlayStatus {
> 
> =head2 GetImportRecordStatus
> 
>-  my $overlay_status = GetImportRecordStatus($import_record_id);
>+  my $status = GetImportRecordStatus($import_record_id);
> 
> =cut
> 
>@@ -1338,25 +1338,25 @@ sub GetImportRecordStatus {
>     my $dbh = C4::Context->dbh;
>     my $sth = $dbh->prepare("SELECT status FROM import_records WHERE import_record_id = ?");
>     $sth->execute($import_record_id);
>-    my ($overlay_status) = $sth->fetchrow_array();
>+    my ($status) = $sth->fetchrow_array();
>     $sth->finish();
>-    return $overlay_status;
>+    return $status;
> 
> }
> 
> 
> =head2 SetImportRecordStatus
> 
>-  SetImportRecordStatus($import_record_id, $new_overlay_status);
>+  SetImportRecordStatus($import_record_id, $new_status);
> 
> =cut
> 
> sub SetImportRecordStatus {
>-    my ($import_record_id, $new_overlay_status) = @_;
>+    my ($import_record_id, $new_status) = @_;
> 
>     my $dbh = C4::Context->dbh;
>     my $sth = $dbh->prepare("UPDATE import_records SET status = ? WHERE import_record_id = ?");
>-    $sth->execute($new_overlay_status, $import_record_id);
>+    $sth->execute($new_status, $import_record_id);
>     $sth->finish();
> 
> }
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13222: 33380 | 33486 | 33538