Attachment 33516 Details for Bug 13234 – Bug 13234: Remove the order by control

[patch] Bug 13234: Remove the order by control

Bug-13234-Remove-the-order-by-control.patch (text/plain), 3.93 KB, created by Jonathan Druart on 2014-11-13 09:20:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-11-13 09:20:33 UTC

Size: 3.93 KB

patch

obsolete

>From e25ddcf88bf526944c2b0cc51b8fe0f67c34ed3a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 13 Nov 2014 10:19:01 +0100
>Subject: [PATCH] Bug 13234: Remove the order by control
>
>Now we have the sort available in the table, the "order by" dropdown list can
>be removed.
>---
> .../bootstrap/en/modules/opac-readingrecord.tt        | 19 ++-----------------
> opac/opac-readingrecord.pl                            | 14 +-------------
> 2 files changed, 3 insertions(+), 30 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>index 6a65000..f08ecff 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>@@ -32,24 +32,14 @@
>                         You have never borrowed anything from this library.
>                     [% ELSE %]
>                         <div id="opac-user-readingrec">
>-                            <div class="resultscontrol resort">
>-                                <form id="sortform" action="/cgi-bin/koha/opac-readingrecord.pl" method="get">
>-                                    [% UNLESS ( limit ) %]<input type="hidden" name="limit" value="full" />[% END %]
>-                                    <select name="order" id="order">
>-                                        [% IF ( orderbydate ) %]<option value="" selected="selected">Order by date</option>[% ELSE %]<option value="">Order by date</option>[% END %]
>-                                        [% IF ( orderbytitle ) %]<option value="title" selected="selected">Order by title</option>[% ELSE %]<option value="title">Order by title</option>[% END %]
>-                                    </select>
>-                                    <input type="submit" value="Go" id="sortsubmit" class="submit clearfix" />
>-                                </form>
>-                            </div>
> 
>                             [% IF limit %]
>                                 <p>
>-                                    Showing last 50 items. <a href="/cgi-bin/koha/opac-readingrecord.pl?limit=full[% IF ( orderbytitle ) %]&amp;order=title[% END %]">Show all items</a>
>+                                    Showing last 50 items. <a href="/cgi-bin/koha/opac-readingrecord.pl?limit=full">Show all items</a>
>                                 </p>
>                             [% ELSE %]
>                                 <p>
>-                                    Showing all items. <a href="/cgi-bin/koha/opac-readingrecord.pl?limit=50[% IF ( orderbytitle ) %]&amp;order=title[% END %]">Show last 50 items</a>
>+                                    Showing all items. <a href="/cgi-bin/koha/opac-readingrecord.pl?limit=50">Show last 50 items</a>
>                                 </p>
>                             [% END %]
> 
>@@ -175,11 +165,6 @@
> //<![CDATA[
>     $(document).ready(function(){
>         [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %]
>-            $('#sortsubmit').hide();
>-        $('#order').change(function() {
>-            $('#sortform').submit();
>-        });
>-
>         var table = $("#readingrec").dataTable($.extend(true, {}, dataTablesDefaults, {
>             "sPaginationType": "four_button",
>             "aoColumnDefs": [
>diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl
>index 6e38cfd..36bec7d 100755
>--- a/opac/opac-readingrecord.pl
>+++ b/opac/opac-readingrecord.pl
>@@ -51,19 +51,7 @@ $template->param(%{$borr});
> 
> my $itemtypes = GetItemTypes();
> 
>-# get the record
>-my $order = $query->param('order') || '';
>-if ( $order eq 'title' ) {
>-    $template->param( orderbytitle => 1 );
>-}
>-elsif ( $order eq 'author' ) {
>-    $template->param( orderbyauthor => 1 );
>-}
>-else {
>-    $order = "date_due desc";
>-    $template->param( orderbydate => 1 );
>-}
>-
>+my $order = "date_due desc";
> 
> my $limit = $query->param('limit');
> $limit = ( $limit eq 'full' ) ? 0 : 50;
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13234: 33488 | 33497 | 33498 | 33515 | 33516 | 33598 | 33599