Bugzilla – Attachment 33533 Details for
Bug 13075
Use of uninitialized value while proving db_dependent/Holds.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13075: (followup) remove remaining warnings
PASSED-QA-Bug-13075-followup-remove-remaining-warn.patch (text/plain), 2.41 KB, created by
Katrin Fischer
on 2014-11-13 20:24:09 UTC
(
hide
)
Description:
[PASSED QA] Bug 13075: (followup) remove remaining warnings
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-11-13 20:24:09 UTC
Size:
2.41 KB
patch
obsolete
>From 1d74addb7f0f663d553133b66a99f47cffe5946f Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 12 Nov 2014 20:39:05 -0300 >Subject: [PATCH] [PASSED QA] Bug 13075: (followup) remove remaining warnings > >There's no point creating a MARC record with undef subfields >for testing holds. This patch avoids that so no warnings are shown. > >To test: >- Run > $ prove t/db_dependent/Holds.t >=> FAIL: verify several warnings show >- Apply the patch >- Re-run >=> SUCCESS: no warnings showed. >- Sign off :-D > >Regards > >NOTE: Not noticable under Ubuntu 12.04 LTS, but verifiable under > Debian Wheezy. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/Holds.t | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t >index 3e2861c..4aee01b 100755 >--- a/t/db_dependent/Holds.t >+++ b/t/db_dependent/Holds.t >@@ -33,10 +33,11 @@ $dbh->do('DELETE FROM itemtypes'); > my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)'); > $insert_sth->execute('CAN'); > $insert_sth->execute('CANNOT'); >+$insert_sth->execute('DUMMY'); > > # Setup Test------------------------ > # Create a biblio instance for testing >-my ($bibnum, $title, $bibitemnum) = create_helper_biblio(); >+my ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY'); > > # Create item instance for testing. > my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum); >@@ -186,7 +187,7 @@ ok( $reserve->{'priority'} eq '5', "Test AlterPriority(), move to bottom" ); > # Note that canreservefromotherbranches has no effect if > # IndependentBranches is OFF. > >-my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio(); >+my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio('DUMMY'); > my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber) > = AddItem({ homebranch => 'MPL', holdingbranch => 'MPL' } , $foreign_bibnum); > $dbh->do('DELETE FROM issuingrules'); >@@ -230,7 +231,7 @@ ok( > ); > > # Regression test for bug 11336 >-($bibnum, $title, $bibitemnum) = create_helper_biblio(); >+($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY'); > ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum); > AddReserve( > $branch, >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13075
:
32282
|
32326
|
32635
|
33503
|
33504
|
33505
|
33532
| 33533