Bugzilla – Attachment 33558 Details for
Bug 11413
Marc modification template has not the expected behavior if the condition and source fields are on the same field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11413: Fix return for ModifyRecordWithTemplate
Bug-11413-Fix-return-for-ModifyRecordWithTemplate.patch (text/plain), 1.96 KB, created by
Marcel de Rooy
on 2014-11-14 09:47:17 UTC
(
hide
)
Description:
Bug 11413: Fix return for ModifyRecordWithTemplate
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-11-14 09:47:17 UTC
Size:
1.96 KB
patch
obsolete
>From d19600266e24f565ceaa195479ae37944ddfe8ee Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 12 Dec 2013 21:14:24 +0100 >Subject: [PATCH] Bug 11413: Fix return for ModifyRecordWithTemplate >Content-Type: text/plain; charset=utf-8 > >Make sure the ModifyRecordWithTemplate routine returns undef. > >This patch also removes a warning if GetModificationTemplates is called >without parameter. > >Verify > prove t/db_dependent/MarcModificationTemplates.t >returns green. > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/MarcModificationTemplates.pm | 2 ++ > t/db_dependent/MarcModificationTemplates.t | 6 ++---- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/MarcModificationTemplates.pm b/C4/MarcModificationTemplates.pm >index 3465f5c..f0cccda 100644 >--- a/C4/MarcModificationTemplates.pm >+++ b/C4/MarcModificationTemplates.pm >@@ -626,6 +626,8 @@ sub ModifyRecordWithTemplate { > > warn( $record->as_formatted() ) if DEBUG >= 10; > } >+ >+ return; > } > 1; > __END__ >diff --git a/t/db_dependent/MarcModificationTemplates.t b/t/db_dependent/MarcModificationTemplates.t >index c41b76a..e8bfcbc 100644 >--- a/t/db_dependent/MarcModificationTemplates.t >+++ b/t/db_dependent/MarcModificationTemplates.t >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-use Test::More tests => 77; >+use Test::More tests => 78; > > use_ok("MARC::Field"); > use_ok("MARC::Record"); >@@ -208,13 +208,11 @@ is( AddModificationTemplateAction( > > my $record = new_record(); > >-ModifyRecordWithTemplate( $template_id, $record ); >+is( ModifyRecordWithTemplate( $template_id, $record ), undef, "The ModifyRecordWithTemplate returns undef" ); > > my $expected_record = expected_record(); > is_deeply( $record, $expected_record, "Record modification as expected"); > >-done_testing; >- > sub new_record { > my $record = MARC::Record->new; > $record->leader('03174nam a2200445 a 4500'); >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11413
:
23622
|
23623
|
23624
|
25758
|
25759
|
25760
|
28993
|
28994
|
28995
|
28996
|
28997
|
28998
|
29502
|
29503
|
29504
|
33213
|
33214
|
33215
|
33482
|
33483
|
33555
|
33556
|
33557
| 33558 |
33559