Attachment 33567 Details for Bug 12778 – [SIGNED-OFF] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts

[patch] [SIGNED-OFF] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts

SIGNED-OFF-Bug-12778---Regression-Item-lost-status.patch (text/plain), 3.58 KB, created by Owen Leonard on 2014-11-14 13:05:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2014-11-14 13:05:35 UTC

Size: 3.58 KB

patch

obsolete

>From e49450241ca387b69f009d4e8dc9fce0ce714a55 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 13 Nov 2014 12:03:42 -0500
>Subject: [PATCH] [SIGNED-OFF] Bug 12778 - Regression: Item lost status
> doesn't show in list of checkouts
>Content-Type: text/plain; charset="utf-8"
>
>When using the longoverdue script it's possible that items marked lost
>remain on the patron account. I think it's important for staff to see
>that some items are marked lost - currently the list of checkouts
>doesn't show any sign of the lost status.
>
>Test Plan:
>1) Find a patron with a checked out lost item
>2) Note the lost status is not displayed in the checkouts table
>3) Apply this patch
>4) Refresh the page, note the lost status now displays
>5) Repeat this test plan for a damaged item
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Tested successfully with damaged and multiple lost values.
>---
> koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 16 +++++++++++++---
> svc/checkouts | 9 +++++++--
> 2 files changed, 20 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>index ece3ff2..a21e928 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>@@ -183,11 +183,21 @@ $(document).ready(function() {
> {
> "iDataSort": 1, // Sort on hidden unformatted date due column
> "mDataProp": function( oObj ) {
>+ var due = oObj.date_due_formatted;
>+
> if ( oObj.date_due_overdue ) {
>- return "" + oObj.date_due_formatted + "";
>- } else {
>- return oObj.date_due_formatted;
>+ due = "" + due + "";
>+ }
>+
>+ if ( oObj.lost ) {
>+ due += "" + oObj.lost + "";
> }
>+
>+ if ( oObj.damaged ) {
>+ due += "" + oObj.damaged + "";
>+ }
>+
>+ return due;
> }
> },
> {
>diff --git a/svc/checkouts b/svc/checkouts
>index 9dc4881..7901d8d 100755
>--- a/svc/checkouts
>+++ b/svc/checkouts
>@@ -25,8 +25,8 @@ use JSON qw(to_json);
> 
> use C4::Auth qw(check_cookie_auth);
> use C4::Biblio qw(GetMarcBiblio GetFrameworkCode GetRecordValue );
>-use C4::Circulation
>- qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate);
>+use C4::Circulation qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate);
>+use C4::Koha qw(GetAuthorisedValueByCode);
> use C4::Context;
> 
> use Koha::DateUtils;
>@@ -86,6 +86,9 @@ my $sql = '
> firstname,
> cardnumber,
> 
>+ itemlost,
>+ damaged,
>+
> DATEDIFF( issuedate, CURRENT_DATE() ) AS not_issued_today
> FROM issues
> LEFT JOIN items USING ( itemnumber )
>@@ -175,6 +178,8 @@ while ( my $c = $sth->fetchrow_hashref() ) {
> GetMarcBiblio( $c->{biblionumber} ),
> GetFrameworkCode( $c->{biblionumber} )
> ),
>+ lost => $c->{itemlost} ? GetAuthorisedValueByCode( 'LOST', $c->{itemlost} ) : undef,
>+ damaged => $c->{damaged} ? GetAuthorisedValueByCode( 'DAMAGED', $c->{damaged} ) : undef,
> borrower => {
> surname => $c->{surname},
> firstname => $c->{firstname},
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12778: 33526 | 33566 | 33567 | 33587