Attachment 33586 Details for Bug 13254 – [PASSED QA] Bug 13254 - Delete record don't wait for confirmation

[patch] [PASSED QA] Bug 13254 - Delete record don't wait for confirmation

PASSED-QA-Bug-13254---Delete-record-dont-wait-for-.patch (text/plain), 2.33 KB, created by Katrin Fischer on 2014-11-15 08:28:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-11-15 08:28:21 UTC

Size: 2.33 KB

patch

obsolete

>From 46a3ec168bbbdde9dd5e9d2063fe73c172c48f6f Mon Sep 17 00:00:00 2001
>From: Rafal Kopaczka <rkk0@poczta.onet.pl>
>Date: Fri, 14 Nov 2014 14:06:22 +0100
>Subject: [PATCH] [PASSED QA] Bug 13254 - Delete record don't wait for
> confirmation
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>In some cases (eg. when Staf Client Search is active), when user choose
>Edit->Delete record on record tool bar, browser don't wait for
>confirmation and goes immediately to delete record.
>
>To reproduce:
>1. Search for some biblio records and choose one without items attached.
>2. Note that there, must be "Return to search results" box on left side,
>bug works in that case, when in normal view everything work fine.
>3. Click Edit->Delete record, watch that confirmation box shows, but
>don't wait for OK and runs immediately. If you are fast enough to
>click OK, then you get error as below, because record was deleted
>earlier.
>
>To test:
>1. Apply patch.
>2. Follow reproduce steps.
>3. Check if waits for confirmation in all cases.
>4. Check if deletes record after confirm.
>
>Followed test plan. Patch behaves as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Confirmed the problem and that the patch fixes it.
>Good catch!
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>index 3044f16..cf72265 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>@@ -199,7 +199,7 @@ CAN_user_serials_create_subscription ) %]
>                 [% IF ( count ) %]
>                     <li class="disabled"><a id="deletebiblio" data-toggle="tooltip" data-placement="left" title="[% count %] item(s) are attached to this record. You must delete all items before deleting this record." href="#">Delete record</a></li>
>                 [% ELSE %]
>-                    <li><a id="deletebiblio" href="/cgi-bin/koha/cataloguing/addbiblio.pl?op=delete&amp;biblionumber=[% biblionumber %]">Delete record</a></li>
>+                    <li><a id="deletebiblio" href="#">Delete record</a></li>
>                 [% END %]
>             [% END %]
> 
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13254: 33568 | 33581 | 33586