Attachment 33641 Details for Bug 13277 – Bug 13277: t/SuggestionEngine_AuthorityFile.t shouldn't depend on the DB

[patch] Bug 13277: t/SuggestionEngine_AuthorityFile.t shouldn't depend on the DB

Bug-13277-tSuggestionEngineAuthorityFilet-shouldnt.patch (text/plain), 2.81 KB, created by Magnus Enger on 2014-11-18 07:45:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2014-11-18 07:45:42 UTC

Size: 2.81 KB

patch

obsolete

>From d6b445ed6850a4474a9b3c2c8c6a3322a928d541 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Mon, 17 Nov 2014 22:59:49 -0500
>Subject: [PATCH] Bug 13277: t/SuggestionEngine_AuthorityFile.t shouldn't
> depend on the DB
>
>To reproduce:
>- Stop your MySQL server:
>  $ sudo service mysql stop
>- Run
>  $ prove t/SuggestionEngine_AuthorityFile.t
>=> FAIL: some tests fail because of mysql stopped
>
>To test (MySQL still stopped)
>- Apply the patch
>- Run
>  $ prove t/SuggestionEngine_AuthorityFile.t
>=> SUCCESS: tests pass because the ycan be loaded regardless of
>            the absence of the DB server
>- Sign off :-D
>
>Regards
>
>Signed-off-by: Magnus Enger <digitalutvikling@gmail.com>
>Turned off MySQL and ran the tests before and after the patch.
>Works as advertized.
>---
> t/SuggestionEngine_AuthorityFile.t |   34 +++++++++++++++++++++++++++++-----
> 1 file changed, 29 insertions(+), 5 deletions(-)
>
>diff --git a/t/SuggestionEngine_AuthorityFile.t b/t/SuggestionEngine_AuthorityFile.t
>index 18a6e42..9ffe8f7 100755
>--- a/t/SuggestionEngine_AuthorityFile.t
>+++ b/t/SuggestionEngine_AuthorityFile.t
>@@ -1,20 +1,42 @@
> #!/usr/bin/perl
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
> #
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
> # This Koha test module uses Test::MockModule to get around the need for known
> # contents in the authority file by returning a single known authority record
> # for every call to SearchAuthorities
> 
>-use strict;
>-use warnings;
>+use Modern::Perl;
>+
> use File::Spec;
> use MARC::Record;
> 
> use Test::More;
> use Test::MockModule;
>+use DBD::Mock;
>+
>+# Mock the DB connexion and C4::Context
>+my $context = new Test::MockModule('C4::Context');
>+$context->mock( '_new_dbh', sub {
>+        my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
>+          || die "Cannot create handle: $DBI::errstr\n";
>+        return $dbh;
>+});
> 
>-BEGIN {
>-        use_ok('Koha::SuggestionEngine');
>-}
>+use_ok('Koha::SuggestionEngine');
> 
> my $module = new Test::MockModule('C4::AuthoritiesMarc');
> $module->mock('SearchAuthorities', sub {
>@@ -41,3 +63,5 @@ my $result = $suggestor->get_suggestions({search => 'Cookery'});
> is_deeply($result, [ { 'search' => 'an=1234', 'relevance' => 1, 'label' => 'Cooking' } ], "Suggested correct alternative to 'Cookery'");
> 
> done_testing();
>+
>+1;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13277: 33634 | 33641 | 33698 | 33712