Attachment 33676 Details for Bug 13293 – Bug 13293 - Regression: Override renewal limit option broken with AJAX circ

[patch] Bug 13293 - Regression: Override renewal limit option broken with AJAX circ

Bug-13293---Regression-Override-renewal-limit-opti.patch (text/plain), 2.16 KB, created by Kyle M Hall (khall) on 2014-11-19 11:32:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-11-19 11:32:42 UTC

Size: 2.16 KB

patch

obsolete

>From 8d1f75061caa987af96a391abe70992fe296bd69 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 19 Nov 2014 05:39:12 -0500
>Subject: [PATCH] Bug 13293 - Regression: Override renewal limit option broken with AJAX circ
>
>The "Override renewal limit" checkbox no longer works to un-hide the
>renewal checkboxes in the table of checkouts. I assume this is because
>the script works in such a way that it is looking for the checkboxes
>before they are part of the document.
>
>Test Plan:
>1) Apply this patch
>2) Check the "Override renewal limit" checkbox
>3) Note the checkbox now appears
>
>Note, this change allows the "X of Y renewals remaining" to be displayed
>for non-renewable items. I left this as it is for two reasons: 1) it
>gives the librarian more information that may be useful, and 2) it looks
>nicer and more uniform.
>---
> koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js |    7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>index 9a022df..5bd7563 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>@@ -321,10 +321,13 @@ $(document).ready(function() {
>                             span_class = "renewals-allowed";
>                         }
> 
>-                        if ( oObj.renewals_remaining && oObj.onsite_checkout == 0 ) {
>+                        if ( oObj.onsite_checkout == 0 ) {
>                             content += "<span class='" + span_class + "' style='" + span_style + "'>"
>                                     +  "<input type='checkbox' ";
>-                            if ( oObj.date_due_overdue ) {
>+                            if ( !oObj.renewals_remaining ) {
>+                                content += "disabled='disabled' ";
>+                            }
>+                            else if ( oObj.date_due_overdue ) {
>                                 content += "checked='checked' ";
>                             }
>                             content += "class='renew' id='renew_" + oObj.itemnumber + "' name='renew' value='" + oObj.itemnumber +"'/>"
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13293: 33676 | 33787 | 33803 | 33805