Attachment 33794 Details for Bug 13214 – [PASSED QA] Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly

[patch] [PASSED QA] Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly

PASSED-QA-Bug-13214---Improve-performance-of-acqui.patch (text/plain), 1.61 KB, created by Kyle M Hall (khall) on 2014-11-21 16:06:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-11-21 16:06:19 UTC

Size: 1.61 KB

patch

obsolete

>From 3b66cb6e05d1dda890f4b82d07f10f022e9cceff Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Thu, 6 Nov 2014 16:38:37 +0200
>Subject: [PATCH] [PASSED QA] Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly
>
>TEST PLAN:
>
>1. Load 167 staged files to Koha.
>2. Try to make an acquisiton from a staged file.
>3. Wait 16s for the acqui/addorderiso2709.pl -view to load.
>
>AFTER PATCH:
>
>1. Load 167 staged files to Koha.
>2. Try to make an acquisiton from a staged file.
>3. Wait 1.6s for the acqui/addorderiso2709.pl -view to load.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> acqui/addorderiso2709.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
>index 666e771..8637a77 100755
>--- a/acqui/addorderiso2709.pl
>+++ b/acqui/addorderiso2709.pl
>@@ -331,7 +331,7 @@ sub import_batches_list {
>     foreach my $batch (@$batches) {
>         if ( $batch->{'import_status'} =~ /^staged$|^reverted$/ ) {
>             # check if there is at least 1 line still staged
>-            my $stagedList=GetImportRecordsRange($batch->{'import_batch_id'}, undef, undef, $batch->{import_status}, { order_by_direction => 'ASC' });
>+            my $stagedList=GetImportRecordsRange($batch->{'import_batch_id'}, undef, 1, $batch->{import_status}, { order_by_direction => 'ASC' });
>             if (scalar @$stagedList) {
>                 push @list, {
>                         import_batch_id => $batch->{'import_batch_id'},
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13214: 33314 | 33322 | 33794