Bugzilla – Attachment 33897 Details for
Bug 10956
Series of OPAC searches can cause a browser crash
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10956 - Series of OPAC searches can cause a browser crash
Bug-10956---Series-of-OPAC-searches-can-cause-a-br.patch (text/plain), 2.34 KB, created by
Jonathan Druart
on 2014-11-25 12:45:59 UTC
(
hide
)
Description:
Bug 10956 - Series of OPAC searches can cause a browser crash
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-11-25 12:45:59 UTC
Size:
2.34 KB
patch
obsolete
>From 9942ab4ca81d6473862fff6985e57c51d977b054 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Wed, 19 Nov 2014 11:40:39 +0100 >Subject: [PATCH] Bug 10956 - Series of OPAC searches can cause a browser crash > >This patch fixes the issue for bootstrap. It was earlier fixed for the prog theme. > >Solution: Prevent jQuery.fn.highlight = function(pat) to be called with empty pat >by skipping empty values in highlight loop. > >To test: >Without patch, do a search as in comment #1 odr #3 >Result: Endless loop (Script not responding) > >Appply patch: >No endless loop, page displays OK > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >To reproduce you need to search a string with 2 spaces. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 28a3686..88bbad2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1354,13 +1354,15 @@ > function highlightOn() { > var x; > for (x in q_array) { >- q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1"); >- q_array[x] = q_array[x].toLowerCase(); >- var myStopwords = "[% Koha.Preference('NotHighlightedWords') %]".toLowerCase().split('|'); >- if( $.inArray(q_array[x], myStopwords) == -1 ) { >- $(".title").highlight(q_array[x]); >- $(".author").highlight(q_array[x]); >- $(".results_summary").highlight(q_array[x]); >+ if ( q_array[x].length > 0 ) { >+ q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1"); >+ q_array[x] = q_array[x].toLowerCase(); >+ var myStopwords = "[% Koha.Preference('NotHighlightedWords') %]".toLowerCase().split('|'); >+ if( $.inArray(q_array[x], myStopwords) == -1 ) { >+ $(".title").highlight(q_array[x]); >+ $(".author").highlight(q_array[x]); >+ $(".results_summary").highlight(q_array[x]); >+ } > } > } > $(".highlight_toggle").toggle(); >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10956
:
33662
|
33667
|
33673
|
33674
|
33897
|
33903