Attachment 339 Details for Bug 1433 – fixing that "bug" rather an enhancement.

[patch] fixing that "bug" rather an enhancement.

0001-Bug-fix-1433.patch (text/plain), 4.32 KB, created by Chris Cormack on 2008-08-05 09:46:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2008-08-05 09:46:00 UTC

Size: 4.32 KB

patch

obsolete

>From 0925b646d7c91ee6ff756155f01f27f198f483cb Mon Sep 17 00:00:00 2001
>From: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
>Date: Tue, 5 Aug 2008 18:40:41 +0200
>Subject: [PATCH] Bug fix : 1433
>
>adding biblionumber as a parameter to serials-home
>adding biblionumber and title as parameter to subscription-add
>using those parameters in biblio-view.
>---
> .../prog/en/includes/biblio-view-menu.inc          |    2 +-
> .../prog/en/includes/serials-toolbar.inc           |    2 +-
> serials/serials-home.pl                            |    1 +
> serials/subscription-add.pl                        |    5 +++++
> 4 files changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>index 07d593e..fc0e749 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>@@ -12,7 +12,7 @@
>     <li class="active"><li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=">Holds</a></li>
>     
> 
>-    <li><a href="/cgi-bin/koha/serials/serials-home.pl?searched=1&amp;title_filter=">Subscription(s)</a></li>
>+    <li><a href="/cgi-bin/koha/serials/serials-home.pl?searched=1&amp;title_filter=&amp;biblionumber=">Subscription(s)</a></li>
> </ul>
> <ul>
> <li class="active"><li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc
>index e76211f..7fca8a8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc
>@@ -50,7 +50,7 @@ onclick: {fn:function(){popup()}}
> 	//]]>
> 	</script>
> <ul class="toolbar">
>-	<li><a id="newsubscription" href="/cgi-bin/koha/serials/subscription-add.pl">New Subscription</a></li>
>+	<li><a id="newsubscription" href="/cgi-bin/koha/serials/subscription-add.pl?biblionumber=&amp;title="><a id="newsubscription" href="/cgi-bin/koha/serials/subscription-add.pl">New Subscription</a></li>
>     
>         
>             <li id="editmenuc"><a id="edit" href="/cgi-bin/koha/serials/subscription-add.pl?op=mod&amp;subscriptionid=">Edit</a></li>
>diff --git a/serials/serials-home.pl b/serials/serials-home.pl
>index 7b0c464..9f88dd2 100755
>--- a/serials/serials-home.pl
>+++ b/serials/serials-home.pl
>@@ -103,6 +103,7 @@ if ($routing) {
>     }
> }
> 
>+$template->param(biblionumber  => $biblionumber ) if (defined($biblionumber));
> $template->param(
>     subscriptions => \@subscriptions,
>     title_filter  => $title,
>diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl
>index 4f96fcd..74db47d 100755
>--- a/serials/subscription-add.pl
>+++ b/serials/subscription-add.pl
>@@ -33,6 +33,7 @@ use C4::Letters;
> 
> my $query = new CGI;
> my $op = $query->param('op');
>+
> my $dbh = C4::Context->dbh;
> my ($subscriptionid,$auser,$branchcode,$librarian,$cost,$aqbooksellerid, $aqbooksellername,$aqbudgetid, $bookfundid, $startdate, $periodicity,
> 	$firstacquidate, $dow, $irregularity, $numberpattern, $numberlength, $weeklength, $monthlength, $sublength,
>@@ -54,6 +55,10 @@ my ($template, $loggedinuser, $cookie)
> 
> 
> 
>+my $biblionumber = $query->param('biblionumber');
>+my $bibliotitle = $query->param('title');
>+$template->param("bibnum"=>$biblionumber,"bibliotitle"=>$bibliotitle) if ($biblionumber);
>+
> my $sub_on;
> my @subscription_types = (
>             'issues', 'weeks', 'months'
>-- 
>1.5.4.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 1433: 339