Bugzilla – Attachment 33952 Details for
Bug 13343
Items are not embedded when sending a basket/shelf
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
B
Bug-13343-Embed-items-when-send-a-basketshelf.patch (text/plain), 3.45 KB, created by
Jonathan Druart
on 2014-11-26 14:17:27 UTC
(
hide
)
Description:
B
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-11-26 14:17:27 UTC
Size:
3.45 KB
patch
obsolete
>From d6768e92179c0ad4c1f18c5107f92b5ab7f1b3fb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 26 Nov 2014 15:14:59 +0100 >Subject: [PATCH] Bug 13343: Embed items when send a basket/shelf > >When a basket/shelf is downloaded, items are embedded, but not when >sending it by email. > >We would expect to get the same file. > >Test plan: >On Opac and intranet: >1/ Add records with items to your basket and send it by email. >Verify the file contains items. >2/ Add records with items to a list and send it by email. >Verify the file contains items. >--- > basket/sendbasket.pl | 2 +- > opac/opac-sendbasket.pl | 2 +- > opac/opac-sendshelf.pl | 2 +- > virtualshelves/sendshelf.pl | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl >index a9314a3..a4e4836 100755 >--- a/basket/sendbasket.pl >+++ b/basket/sendbasket.pl >@@ -72,7 +72,7 @@ if ( $email_add ) { > $template2->param( biblionumber => $biblionumber ); > > my $dat = GetBiblioData($biblionumber); >- my $record = GetMarcBiblio($biblionumber); >+ my $record = GetMarcBiblio($biblionumber, 1); > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); >diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl >index 8143cca..2aad93a 100755 >--- a/opac/opac-sendbasket.pl >+++ b/opac/opac-sendbasket.pl >@@ -87,7 +87,7 @@ if ( $email_add ) { > $template2->param( biblionumber => $biblionumber ); > > my $dat = GetBiblioData($biblionumber); >- my $record = GetMarcBiblio($biblionumber); >+ my $record = GetMarcBiblio($biblionumber, 1); > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); >diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl >index b662664..ba08abb 100755 >--- a/opac/opac-sendshelf.pl >+++ b/opac/opac-sendshelf.pl >@@ -85,7 +85,7 @@ if ( $email ) { > my $biblionumber = $biblio->{biblionumber}; > my $fw = GetFrameworkCode($biblionumber); > my $dat = GetBiblioData($biblionumber); >- my $record = GetMarcBiblio($biblionumber); >+ my $record = GetMarcBiblio($biblionumber, 1); > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); >diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl >index 1d41581..61c42ad 100755 >--- a/virtualshelves/sendshelf.pl >+++ b/virtualshelves/sendshelf.pl >@@ -81,7 +81,7 @@ if ($email) { > my $biblionumber = $biblio->{biblionumber}; > my $fw = GetFrameworkCode($biblionumber); > my $dat = GetBiblioData($biblionumber); >- my $record = GetMarcBiblio($biblionumber); >+ my $record = GetMarcBiblio($biblionumber, 1); > my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); > my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13343
:
33952
|
34623
|
34708