Bugzilla – Attachment 33983 Details for
Bug 1861
Unique patrons logins not (totally) enforced
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PUSHED] Bug 1861 - Unique patrons logins not (totally) enforced
PASSED-QA-Bug-1861---Unique-patrons-logins-not-tot.patch (text/plain), 2.94 KB, created by
Martin Renvoize (ashimema)
on 2014-11-27 09:07:42 UTC
(
hide
)
Description:
[PUSHED] Bug 1861 - Unique patrons logins not (totally) enforced
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2014-11-27 09:07:42 UTC
Size:
2.94 KB
patch
obsolete
>From caa844fa61e27d0c7e8682a554e3e9491ba19e8c Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 8 Jul 2014 09:50:08 -0400 >Subject: [PATCH] [PASSED QA] Bug 1861 - Unique patrons logins not (totally) > enforced > >The Koha 3.0 patron admin page will prevent you from creating a user who >has an identical OPAC login as someone else (though I would change the >error message from "Login/password already exists." to "Login >already exists.", since it's not the password that's the >problem). > >However, there's nothing enforced in the MySQL database to prevent >patrons from being imported or manually inserted with duplicate logins. >Would it be better to change the MySQL spec from this: >KEY `userid` (`userid`) >to this: >UNIQUE KEY `userid` (`userid`) > >Test plan: >1) Enter mysql console >2) Attempt to create two borrowers with identical user id's >3) Note you are able to do so >4) Delete these bororwers >5) Apply this patch >6) Run updatedatabase.pl >7) Repeat step 2 >8) Note you are now unable to do so > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Work as described, no koha-qa errors > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Leaves deletedborrowers as it is, deleting patrons still works ok. >Works according to test plan. >Database update will only be successful, when no duplicate entries >exist in the database. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/kohastructure.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+), 1 deletion(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 4ffbbf2..a2f3e07 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -269,7 +269,7 @@ CREATE TABLE `borrowers` ( -- this table includes information about your patrons > PRIMARY KEY `borrowernumber` (`borrowernumber`), > KEY `categorycode` (`categorycode`), > KEY `branchcode` (`branchcode`), >- KEY `userid` (`userid`), >+ UNIQUE KEY `userid` (`userid`), > KEY `guarantorid` (`guarantorid`), > KEY `surname_idx` (`surname`(255)), > KEY `firstname_idx` (`firstname`(255)), >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 393a3a1..9600018 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -9573,6 +9573,22 @@ if ( CheckVersion($DBversion) ) { > SetVersion($DBversion); > } > >+$DBversion = "3.17.00.XXX"; >+if ( CheckVersion($DBversion) ) { >+ $dbh->do(q{ >+ UPDATE borrowers SET userid = NULL where userid = "" >+ }); >+ >+ $dbh->do(q{ >+ ALTER TABLE borrowers >+ DROP INDEX userid , >+ ADD UNIQUE userid (userid) >+ }); >+ >+ print "Upgrade to $DBversion done (Bug 1861 - Unique patrons logins not (totally) enforced)\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 1861
:
29573
|
29616
|
30561
|
30828
|
33143
|
33144
|
33749
|
33750
|
33751
|
33752
| 33983 |
33984
|
33985
|
34820
|
34821
|
34822
|
34823