Bugzilla – Attachment 33993 Details for
Bug 13355
System preferences tab value wrong in templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13355: System preferences tab value wrong in templates
Bug-13355-System-preferences-tab-value-wrong-in-te.patch (text/plain), 3.02 KB, created by
Tomás Cohen Arazi (tcohen)
on 2014-11-27 12:17:18 UTC
(
hide
)
Description:
Bug 13355: System preferences tab value wrong in templates
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2014-11-27 12:17:18 UTC
Size:
3.02 KB
patch
obsolete
>From 9bed7e3b55951944dab73caa1624eddb89ea442d Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Thu, 27 Nov 2014 09:13:14 -0300 >Subject: [PATCH] Bug 13355: System preferences tab value wrong in templates > >This patch fixes a bug on the system preferences tab templates. > >To test: >To reproduce: >(1) >- Choose a tab on the sysprefs section (for example 'Enhanced Content') >- Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code >=> FAIL: you will see below the form tag something like: ><input type="hidden" name="op" value="save"> ><input type="hidden" name="tab" value=""> > >(2) >- Do a syspref search (for example 'facet'). >- Right click on one of the category titles (for example 'OPAC preferences') >=> FAIL: you will see below the form tag something like: ><input type="hidden" name="op" value="save"> ><input type="hidden" name="tab" value="HASH(0x6e53050)"> > >- Apply the patch >- Repeat (1) and (2) >=> SUCCESS: you will see below the form tag something like: > ><input type="hidden" name="tab" value="enhanced_content"> >and ><input type="hidden" name="tab" value="opac"> > >respectively. >- Sign off :-D > >Regards >--- > admin/preferences.pl | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/admin/preferences.pl b/admin/preferences.pl >index f791095..dbc3644 100755 >--- a/admin/preferences.pl >+++ b/admin/preferences.pl >@@ -262,7 +262,7 @@ sub SearchPrefs { > if ( $matched_groups ) { > my ( $title, $LINES ) = TransformPrefsToHTML( { $title => $matched_groups }, $searchfield ); > >- push @tabs, { tab => $tab, tab_title => $title, LINES => $LINES, }; >+ push @tabs, { tab => $tab, tab_title => $title, LINES => $LINES, tab_id => $tab_name }; > } > } > >@@ -346,7 +346,7 @@ if ( $op eq 'search' ) { > if ( $tab ) { > my ( $tab_title, $LINES ) = TransformPrefsToHTML( GetTab( $input, $tab ), $highlighted ); > >- push @TABS, { tab_title => $tab_title, LINES => $LINES }; >+ push @TABS, { tab_title => $tab_title, LINES => $LINES, tab_id => $tab }; > $template->param( > $tab => 1, > tab => $tab, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index dde4764..3a5f2b8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -76,7 +76,7 @@ > <form action="/cgi-bin/koha/admin/preferences.pl" method="post"> > [% UNLESS ( searchfield ) %]<div id="toolbar"><button class="save-all submit" type="submit">Save all [% TAB.tab_title %] preferences</button></div>[% END %] > <input type="hidden" name="op" value="save" /> >- <input type="hidden" name="tab" value="[% TAB.tab %]" /> >+ <input type="hidden" name="tab" value="[% TAB.tab_id %]" /> > > [% FOREACH LINE IN TAB.LINES %] > [% IF ( LINE.is_group_title ) %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13355
:
33993
|
34005
|
34006
|
34149