Attachment 34000 Details for Bug 9165 – Bug 12831 [QA Followup]: Tidied code slightly

[patch] Bug 12831 [QA Followup]: Tidied code slightly

Bug-12831-QA-Followup-Tidied-code-slightly.patch (text/plain), 1.32 KB, created by Julian Maurice on 2014-11-27 16:09:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2014-11-27 16:09:47 UTC

Size: 1.32 KB

patch

obsolete

>From b8a43b2b79615035f18e83380d20db6931d0cccc Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 27 Nov 2014 15:31:24 +0000
>Subject: [PATCH] Bug 12831 [QA Followup]: Tidied code slightly
>
>Minor code tidy to clean up qa script warning.
>
>http://bugs.koha-community.org/show_bug.cgi?id=9165
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> C4/Auth_with_ldap.pm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm
>index 5f0bb19..42accc3 100644
>--- a/C4/Auth_with_ldap.pm
>+++ b/C4/Auth_with_ldap.pm
>@@ -300,11 +300,12 @@ sub _do_changepassword {
>         my $sth = C4::Context->dbh->prepare(
>             'SELECT cardnumber FROM borrowers WHERE borrowernumber=?');
>         $sth->execute($borrowerid);
>-        die
>-"Unable to access borrowernumber with userid=$userid, borrowernumber=$borrowerid"
>+        die "Unable to access borrowernumber "
>+            . "with userid=$userid, "
>+            . "borrowernumber=$borrowerid"
>           if !$sth->rows;
>         my ($cardnum) = $sth->fetchrow;
>-        my $sth = C4::Context->dbh->prepare(
>+        $sth = C4::Context->dbh->prepare(
>             'UPDATE borrowers SET password = null WHERE borrowernumber=?');
>         $sth->execute($borrowerid);
>         return $cardnum;
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 9165: 13752 | 13753 | 13754 | 18535 | 27380 | 33872 | 33873 | 33884 | 33997 | 33998 | 33999 | 34000