Attachment 34127 Details for Bug 12059 – Bug 12059: Prefer to list fields in the query

[patch] Bug 12059: Prefer to list fields in the query

Bug-12059-Prefer-to-list-fields-in-the-query.patch (text/plain), 1.09 KB, created by Jonathan Druart on 2014-12-04 15:06:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-12-04 15:06:46 UTC

Size: 1.09 KB

patch

obsolete

>From 8f7dc05d13944d92ddd42317c2beed70dbe757f5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 4 Dec 2014 16:05:34 +0100
>Subject: [PATCH] Bug 12059: Prefer to list fields in the query
>
>To avoir further issue, it's better to explicitely list the fields we
>want to retrieve.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> C4/Acquisition.pm | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index 51d7102..d66f156 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -2644,7 +2644,11 @@ sub GetInvoiceDetails {
>     my $invoice = $sth->fetchrow_hashref;
> 
>     $query = q{
>-        SELECT aqorders.*, biblio.*, biblioitems.*, aqbasket.basketname
>+        SELECT aqorders.*, biblio.*,
>+        biblio.copyrightdate,
>+        biblioitems.publishercode,
>+        biblioitems.publicationyear,
>+        aqbasket.basketname
>         FROM aqorders
>           LEFT JOIN aqbasket ON aqorders.basketno = aqbasket.basketno
>           LEFT JOIN biblio ON aqorders.biblionumber = biblio.biblionumber
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 12059: 33411 | 34088 | 34126 | 34127