Attachment 34148 Details for Bug 13368 – [PASSED QA] Bug 13368 Holds priority messed up on checkout

[patch] [PASSED QA] Bug 13368 Holds priority messed up on checkout

PASSED-QA-Bug-13368-Holds-priority-messed-up-on-ch.patch (text/plain), 1.26 KB, created by Kyle M Hall (khall) on 2014-12-05 15:06:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-12-05 15:06:19 UTC

Size: 1.26 KB

patch

obsolete

>From 63b983369f971334b3f24b0f75d60f60c3263a70 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Tue, 2 Dec 2014 14:16:40 +1300
>Subject: [PATCH] [PASSED QA] Bug 13368 Holds priority messed up on checkout
>
>To Test
>
>1/ Create 3 (or more holds) on one biblionumber, make sure at least
>one item is not on loan
>2/ Check out the not on loan item to a borrower (maybe number 2 in the
>queue)
>3/ Look in the database (or on the holds tab on the moredetail.pl)
>notice the priorities have not been reordered
>4/ Apply patch and try again, notice now they have
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Confirmed the problem without the patch, and confirmed that the patch
>corrects it.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Reserves.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 5058c51..22a9ecb 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1309,7 +1309,7 @@ sub ModReserveFill {
>     # now fix the priority on the others (if the priority wasn't
>     # already sorted!)....
>     unless ( $priority == 0 ) {
>-        _FixPriority({ reserve_id => $reserve_id });
>+        _FixPriority({ reserve_id => $reserve_id, biblionumber => $biblionumber });
>     }
> }
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13368: 34051 | 34064 | 34148