Bugzilla – Attachment 34150 Details for
Bug 13318
C4::Acq::GetParcel is not used and can be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13318: Delete C4::Acq::GetParcel
PASSED-QA-Bug-13318-Delete-C4AcqGetParcel.patch (text/plain), 3.58 KB, created by
Kyle M Hall (khall)
on 2014-12-05 15:10:27 UTC
(
hide
)
Description:
[PASSED QA] Bug 13318: Delete C4::Acq::GetParcel
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-12-05 15:10:27 UTC
Size:
3.58 KB
patch
obsolete
>From 5a726b917b15ce1c876686f0c18102f707cb894a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 14 Nov 2014 11:15:08 +0100 >Subject: [PATCH] [PASSED QA] Bug 13318: Delete C4::Acq::GetParcel > >Test plan: > git grep GetParcel >should not return use of this subroutine. > >Signed-off-by: wajasu <matted@34813.mypacks.net> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Acquisition.pm | 73 +---------------------------------------------------- > 1 files changed, 1 insertions(+), 72 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index ecf96fe..27cef63 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -65,7 +65,7 @@ BEGIN { > &GetLastOrderNotReceivedFromSubscriptionid &GetLastOrderReceivedFromSubscriptionid > &ModItemOrder > >- &GetParcels &GetParcel >+ &GetParcels > > &GetInvoices > &GetInvoice >@@ -1895,77 +1895,6 @@ sub TransferOrder { > > =head2 FUNCTIONS ABOUT PARCELS > >-=cut >- >-#------------------------------------------------------------# >- >-=head3 GetParcel >- >- @results = &GetParcel($booksellerid, $code, $date); >- >-Looks up all of the received items from the supplier with the given >-bookseller ID at the given date, for the given code (bookseller Invoice number). Ignores cancelled and completed orders. >- >-C<@results> is an array of references-to-hash. The keys of each element are fields from >-the aqorders, biblio, and biblioitems tables of the Koha database. >- >-C<@results> is sorted alphabetically by book title. >- >-=cut >- >-sub GetParcel { >- #gets all orders from a certain supplier, orders them alphabetically >- my ( $supplierid, $code, $datereceived ) = @_; >- my $dbh = C4::Context->dbh; >- my @results = (); >- $code .= '%' >- if $code; # add % if we search on a given code (otherwise, let him empty) >- my $strsth =" >- SELECT authorisedby, >- creationdate, >- aqbasket.basketno, >- closedate,surname, >- firstname, >- aqorders.biblionumber, >- aqorders.ordernumber, >- aqorders.parent_ordernumber, >- aqorders.quantity, >- aqorders.quantityreceived, >- aqorders.unitprice, >- aqorders.listprice, >- aqorders.rrp, >- aqorders.ecost, >- aqorders.gstrate, >- biblio.title >- FROM aqorders >- LEFT JOIN aqbasket ON aqbasket.basketno=aqorders.basketno >- LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber >- LEFT JOIN biblio ON aqorders.biblionumber=biblio.biblionumber >- LEFT JOIN aqinvoices ON aqorders.invoiceid = aqinvoices.invoiceid >- WHERE >- aqbasket.booksellerid = ? >- AND aqinvoices.invoicenumber LIKE ? >- AND aqorders.datereceived = ? "; >- >- my @query_params = ( $supplierid, $code, $datereceived ); >- if ( C4::Context->preference("IndependentBranches") ) { >- unless ( C4::Context->IsSuperLibrarian() ) { >- $strsth .= " and (borrowers.branchcode = ? >- or borrowers.branchcode = '')"; >- push @query_params, C4::Context->userenv->{branch}; >- } >- } >- $strsth .= " ORDER BY aqbasket.basketno"; >- my $result_set = $dbh->selectall_arrayref( >- $strsth, >- { Slice => {} }, >- @query_params); >- >- return @{$result_set}; >-} >- >-#------------------------------------------------------------# >- > =head3 GetParcels > > $results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13318
:
33774
|
34011
| 34150