Attachment 34156 Details for Bug 13017 – [PASSED QA] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels

[patch] [PASSED QA] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels

PASSED-QA-Bug-13017---Login-page-image-replacement.patch (text/plain), 1.71 KB, created by Kyle M Hall (khall) on 2014-12-05 15:43:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-12-05 15:43:19 UTC

Size: 1.71 KB

patch

obsolete

>From 5035f63da91745e93cf36702950653192f291573 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 3 Nov 2014 12:29:48 -0500
>Subject: [PATCH] [PASSED QA] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels
>
>This patch updates the image replacement technique used for Koha's login
>page. The old technique used a negative text-indent value to move the
>text offscreen, but that begins to fail more and more often as screens
>get larger.
>
>The new technqiue is described here:
>http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/
>
>Note: This patch has not been tested in any Internet Explorer version!
>
>To test you must have a screen which is wider than 2000 pixels. Apply
>the patch, clear your browser cache and view the staff client login
>page. The logo on the login form should look correct with no
>corresponding text appearing anywhere on the screen.
>
>Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/css/login.css |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/login.css b/koha-tmpl/intranet-tmpl/prog/en/css/login.css
>index 6712f92..61988a2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/login.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/login.css
>@@ -84,10 +84,12 @@ label {
> }
> 
> #login h1 a {
>+    /* http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/ */
> 	display: block;
>-	text-indent: -1000px;
> 	height: 74px;
>-	border-bottom: none;
>+    text-indent: 100%;
>+    white-space: nowrap;
>+    overflow: hidden;
> }
> 
> #login input {
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13017: 31959 | 33462 | 34045 | 34156