Attachment 34196 Details for Bug 6679 – Bug 6679 - Fixing code so it passes basic Perl:::Critic tests

[patch] Bug 6679 - Fixing code so it passes basic Perl:::Critic tests

Bug-6679---Fixing-code-so-it-passes-basic-PerlCrit.patch (text/plain), 1.19 KB, created by Jonathan Druart on 2014-12-09 08:53:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-12-09 08:53:03 UTC

Size: 1.19 KB

patch

obsolete

>From 3b126e35fbd64a0e76cd5f980360572c48f2485b Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Tue, 25 Sep 2012 11:21:43 +1200
>Subject: [PATCH] Bug 6679 - Fixing code so it passes basic Perl:::Critic tests
>
>opac/ilsdi.pl: Stricture disabled at line 217, column 17.  See page 429 of PBP.  (Severity: 5)
>---
> opac/ilsdi.pl | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/opac/ilsdi.pl b/opac/ilsdi.pl
>index a8cc47d..7399ebb 100755
>--- a/opac/ilsdi.pl
>+++ b/opac/ilsdi.pl
>@@ -17,15 +17,14 @@
> # with Koha; if not, write to the Free Software Foundation, Inc.,
> # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> 
>-use strict;
>-use warnings;
>-
>-use List::MoreUtils qw(any);
>+use Modern::Perl;
> 
> use C4::ILSDI::Services;
> use C4::Auth;
> use C4::Output;
> use C4::Context;
>+
>+use List::MoreUtils qw(any);
> use XML::Simple;
> use CGI;
> 
>@@ -217,7 +216,7 @@ if ( $service and any { $service eq $_ } @services ) {
> 
>             # Variable functions
>             my $sub = do {
>-                no strict 'refs';
>+#                no strict 'refs';
>                 my $symbol = 'C4::ILSDI::Services::' . $service;
>                 \&{"$symbol"};
>             };
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208