Attachment 34235 Details for Bug 13415 – [SIGNED OFF] Bug 13415 - Prevent librarians from scanning multiple items into a single barcode field

[patch] [SIGNED OFF] Bug 13415 - Prevent librarians from scanning multiple items into a single barcode field

SIGNED-OFF-Bug-13415---Prevent-librarians-from-sca.patch (text/plain), 3.15 KB, created by Martin Renvoize (ashimema) on 2014-12-09 15:18:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2014-12-09 15:18:42 UTC

Size: 3.15 KB

patch

obsolete

>From 35a87159b5907792b56d268e880ee39b6a050da2 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 9 Dec 2014 06:30:36 -0500
>Subject: [PATCH] [SIGNED OFF] Bug 13415 - Prevent librarians from scanning
> multiple items into a single barcode field
>
>It appears that some librarians will attempt to scan items as fast as
>they can without checking to make sure the checkout was submitted and
>the page reloaded properly. This can cause multiple barcodes to be
>scanned into the barcode field if the person is fast enough.
>This causes the checkout of both ( or more! ) items to fail.
>
>Test Plan:
>1) Apply this patch
>2) Attempt to scan two or more items into the barcode field
>   You can emulate this with a keybaord by hitting a few keys, then
>   enter, then a few more keys, then enter again. The barcodes don't
>   need to be valid for this test.
>3) Note the dialog stating the barcode has been submitted and to please
>   wait.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/circ/circulation.tt            |   27 ++++++++++++++++----
> 1 file changed, 22 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index b938724..04b9d61 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -60,6 +60,17 @@ function toggle_onsite_checkout(){
> }
> 
> $(document).ready(function() {
>+    [% IF !NEEDSCONFIRMATION %]
>+        $('#barcode').prop('disabled', false).focus();
>+    [% END %]
>+    $('#mainform').bind('submit',function() {
>+        $('#barcode').on('keypress',function(event) {
>+            $('#barcodeSubmittedModal').modal();
>+            event.preventDefault(); }
>+        );
>+    });
>+
>+
>     [% IF !( CircAutoPrintQuickSlip == 'clear' ) %]
>         // listen submit to trigger qslip on empty checkout
>         $('#mainform').bind('submit',function() {
>@@ -528,11 +539,7 @@ No patron matched <span class="ex">[% message %]</span>
> 
> 	<div class="hint">Enter item barcode:</div>
> 
>-    [% IF NEEDSCONFIRMATION %]
>-	    <input type="text" name="barcode" id="barcode" class="barcode focus" size="14" disabled="disabled" />
>-    [% ELSE %]
>-	    <input type="text" name="barcode" id="barcode" class="barcode focus" size="14" />
>-    [% END %]
>+    <input type="text" name="barcode" id="barcode" class="barcode focus" size="14" disabled="disabled" />
>     <button type="submit" class="btn">Check out</button>
> 
>     <div class="date-select">
>@@ -871,4 +878,14 @@ No patron matched <span class="ex">[% message %]</span>
> [% INCLUDE 'circ-menu.inc' %]
> </div>[% END %][% END %]
> </div>
>+
>+<div id="barcodeSubmittedModal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="barcodeSubmittedModalLabel" aria-hidden="true">
>+    <div class="modal-header">
>+        <h3 id="barcodeSubmittedModalLabel">Barcode submitted</h3>
>+    </div>
>+
>+    <div class="modal-body">
>+        <p>You have already submitted a barcode, please wait for the checkout to process...</p>
>+    </div>
>+</div>
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13415: 34202 | 34203 | 34235 | 34341 | 34380 | 34381