Bugzilla – Attachment 34260 Details for
Bug 13425
There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13425 - XSS in opac facets - Patch for master and 3.18
Bug-13425---XSS-in-opac-facets---Patch-for-master-.patch (text/plain), 2.19 KB, created by
Brendan Gallagher
on 2014-12-10 00:05:30 UTC
(
hide
)
Description:
Bug 13425 - XSS in opac facets - Patch for master and 3.18
Filename:
MIME Type:
Creator:
Brendan Gallagher
Created:
2014-12-10 00:05:30 UTC
Size:
2.19 KB
patch
obsolete
>From d3f9fffc5b2e045bce1a6cef7251b15df4746153 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed, 10 Dec 2014 12:47:30 +1300 >Subject: [PATCH] Bug 13425 - XSS in opac facets - Patch for master and 3.18 > >To Test >1/ Craft a url like /cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123 > >It is important it must return results and facets > >2/ Notice the js is executed >3/ Apply the patch test again > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >index 7044bfd..e1b69a5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >@@ -42,10 +42,10 @@ > [% IF facet.active %] > [% SET url = url _ "&nolimit=" _ facet.type_link_value _ ":" _ facet.facet_link_value %] > <span class="facet-label">[% facet.facet_label_value %]</span> >- [<a href="[% url %]" title="Remove facet [% facet.facet_link_value | html %]">x</a>] >+ [<a href="[% url |url%]" title="Remove facet [% facet.facet_link_value | html %]">x</a>] > [% ELSE %] > [% SET url = url _ "&limit=" _ facet.type_link_value _ ":" _ facet.facet_link_value %] >- <span class="facet-label"><a href="[% url %]" title="[% facet.facet_title_value |html %]">[% facet.facet_label_value %]</a></span> >+ <span class="facet-label"><a href="[% url |url%]" title="[% facet.facet_title_value |html %]">[% facet.facet_label_value %]</a></span> > [% IF ( displayFacetCount ) %] > <span class="facet-count"> ([% facet.facet_count %])</span> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13425
:
34255
|
34256
|
34257
|
34258
|
34259
|
34260
|
34261
|
34262
|
34264
|
34265
|
34267
|
34273
|
34389
|
34496
|
34507
|
34603
|
34617
|
34618
|
34619
|
34636