Attachment 34264 Details for Bug 13425 – [PUSHED] Bug 13425 - XSS in intranet facets - Patch for 3.16

[patch] [PUSHED] Bug 13425 - XSS in intranet facets - Patch for 3.16

Bug-13425---XSS-in-intranet-facets---Patch-for-316.patch (text/plain), 1.52 KB, created by Jared Camins-Esakov on 2014-12-10 04:42:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2014-12-10 04:42:49 UTC

Size: 1.52 KB

patch

obsolete

>From 98db10b2bdd6a7c786a583d1403575fbb240f58d Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Wed, 10 Dec 2014 12:47:30 +1300
>Subject: [PATCH] Bug 13425 - XSS in intranet facets - Patch for 3.16
>
>To Test
>1/ Craft a url like /cgi-bin/koha/catalogue/search.pl?q=smith&sort_by='"><script>prompt('Happy_Holidays')</script>
>
>It is important it must return results and facets
>
>2/ Notice the js is executed
>3/ Apply the patch test again
>
>Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>index 97891eb..59a88c1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>@@ -36,7 +36,7 @@
>         [<a href="[% url %]" title="Remove facet [% facet.facet_title_value | html %]">x</a>]
>       [% ELSE %]
>         [% SET url = url _ "&amp;limit=" _ facet.type_link_value _ ":" _ facet.facet_link_value %]
>-        <span class="facet-label"><a href="[% url %]" title="[% facet.facet_title_value |html %]">[% facet.facet_label_value %]</a></span>
>+        <span class="facet-label"><a href="[% url |url%]" title="[% facet.facet_title_value |html %]">[% facet.facet_label_value %]</a></span>
>         [% IF ( displayFacetCount ) %]
>           <span class="facet-count"> ([% facet.facet_count %])</span>
>         [% END %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13425: 34255 | 34256 | 34257 | 34258 | 34259 | 34260 | 34261 | 34262 | 34264 | 34265 | 34267 | 34273 | 34389 | 34496 | 34507 | 34603 | 34617 | 34618 | 34619 | 34636