Bugzilla – Attachment 34346 Details for
Bug 13400
Untranslatable "Are you sure you want to delete this authority?"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?"
PASSED-QA-Bug-13400---Untranslatable-Are-you-sure-.patch (text/plain), 2.45 KB, created by
Kyle M Hall (khall)
on 2014-12-12 14:11:40 UTC
(
hide
)
Description:
[PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?"
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-12-12 14:11:40 UTC
Size:
2.45 KB
patch
obsolete
>From 2c03b682c097ad2dfbb8ce2f0ac92e46f64ad84d Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Mon, 8 Dec 2014 03:55:15 +0100 >Subject: [PATCH] [PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" > >This patch makes the string "Are you sure you want to delete this >authority?" translatable using the function _(...) > >To test, apply patch and check that deleting authorities still works. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Tested successfully with the following procedure: > >1. Applied the patch. >2. Ran perl translate update de-DE >3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" >4. Removed "#, fuzzy" marker from po entry. >5. perl translate -v install de-DE >6. Testing deleting an authority from the authority search results page > and from the detail page. My translated string appeared correctly. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/authorities/detail.tt | 2 +- > .../en/modules/authorities/searchresultlist.tt | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >index 427e6b0..561ac96 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt >@@ -32,7 +32,7 @@ > }); > > function confirm_deletion() { >- var is_confirmed = confirm('Are you sure you want to delete this authority?'); >+ var is_confirmed = confirm(_('Are you sure you want to delete this authority?')); > if (is_confirmed) { > window.location="authorities-home.pl?op=delete&authid=[% authid %]"; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >index ebe5491..90da56e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >@@ -5,8 +5,7 @@ > <script type="text/javascript" > > //<![CDATA[ > function confirm_deletion(id) { >- >- var is_confirmed = confirm('Are you sure you want to delete this authority?'); >+ var is_confirmed = confirm(_('Are you sure you want to delete this authority?')); > if (is_confirmed) { > window.location="authorities-home.pl?op=delete" > + "&authid=" + id >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13400
:
34176
|
34278
|
34346
|
34347
|
34348