Bugzilla – Attachment 34360 Details for
Bug 13453
Koha.t daily quote tests assume sample data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13453: Koha.t daily quote tests assume sample data
Bug-13453-Kohat-daily-quote-tests-assume-sample-da.patch (text/plain), 1.62 KB, created by
Mark Tompsett
on 2014-12-12 17:31:12 UTC
(
hide
)
Description:
Bug 13453: Koha.t daily quote tests assume sample data
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-12-12 17:31:12 UTC
Size:
1.62 KB
patch
obsolete
>From 88de0890009bc8720d588de00119b6db4a96bdb2 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 12 Dec 2014 12:28:11 -0500 >Subject: [PATCH] Bug 13453: Koha.t daily quote tests assume sample data > >By adding quotes 3 and 25 from the sample data, this test can >pass without having the sample quote data loaded. > >TEST PLAN >--------- >1) Ensure there is no quote id=3 or that it is NOT > Abraham Lincoln. >2) prove t/db_dependent/Koha.t > -- this should fail the daily quote test. >3) apply patch >4) prove t/db_dependent/Koha.t > -- this should fail the daily quote test. >5) run koha qa test tools >--- > t/db_dependent/Koha.t | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/t/db_dependent/Koha.t b/t/db_dependent/Koha.t >index e40b4c2..2a6850a 100644 >--- a/t/db_dependent/Koha.t >+++ b/t/db_dependent/Koha.t >@@ -174,6 +174,13 @@ SKIP: > > skip "C4::Koha can't \'GetDailyQuote\'!", 3 unless can_ok('C4::Koha','GetDailyQuote'); > >+# Fill the quote table with the default needed and a spare >+$dbh->do("DELETE FROM quotes WHERE id=3 OR id=25;"); >+my $sql = "INSERT INTO quotes (id,source,text,timestamp) VALUES >+(25,'Richard Nixon','When the President does it, that means that it is not illegal.','0000-00-00 00:00:00'), >+(3,'Abraham Lincoln','Four score and seven years ago our fathers brought forth on this continent, a new nation, conceived in Liberty, and dedicated to the proposition that all men are created equal.','0000-00-00 00:00:00');"; >+$dbh->do($sql); >+ > my $expected_quote = { > id => 3, > source => 'Abraham Lincoln', >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13453
:
34360
|
34606
|
34698