Bugzilla – Attachment 34383 Details for
Bug 13461
Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used
Bug-13461---Circ-always-asking-for-confirmation-if.patch (text/plain), 1.17 KB, created by
Katrin Fischer
on 2014-12-14 21:32:50 UTC
(
hide
)
Description:
Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-12-14 21:32:50 UTC
Size:
1.17 KB
patch
obsolete
>From 56dae74a3d0dcb9930a390785f39e7082dd70c6b Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 14 Dec 2014 22:31:04 +0100 >Subject: [PATCH] Bug 13461 - Circ always asking for confirmation if > RentalFeesCheckoutConfirmation is used > >To test: >- Check RentalFeesCheckoutConfirmation is activated >- Try to check out an item without rental fine >- Verify confirmation message without explanation > is shown >- Apply patch >- Verify confirmation message is no longer shown >- Configure itemtype to have rental fee >- Veirfy now the confirmation message appears as > it should >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index f24f2f7..5f7e866 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -928,7 +928,7 @@ sub CanBookBeIssued { > > if ( $rentalConfirmation ){ > my ($rentalCharge) = GetIssuingCharges( $item->{'itemnumber'}, $borrower->{'borrowernumber'} ); >- if ( $rentalCharge ){ >+ if ( $rentalCharge > 0 ){ > $rentalCharge = sprintf("%.02f", $rentalCharge); > $needsconfirmation{RENTALCHARGE} = $rentalCharge; > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13461
:
34383
|
34415
|
34450