Attachment 34415 Details for Bug 13461 – Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used

[patch] Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used

0001-Bug-13461-Circ-always-asking-for-confirmation-if-Ren.patch (text/plain), 1.27 KB, created by Paola Rossi on 2014-12-15 12:41:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paola Rossi

Created: 2014-12-15 12:41:01 UTC

Size: 1.27 KB

patch

obsolete

>From 6cd7a11ac9568a31eb3b308a285f925c2c507500 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sun, 14 Dec 2014 22:31:04 +0100
>Subject: [PATCH] Bug 13461 - Circ always asking for confirmation if
> RentalFeesCheckoutConfirmation is used
>
>To test:
>- Check RentalFeesCheckoutConfirmation is activated
>- Try to check out an item without rental fine
>- Verify confirmation message without explanation
>  is shown
>- Apply patch
>- Verify confirmation message is no longer shown
>- Configure itemtype to have rental fee
>- Veirfy now the confirmation message appears as
>  it should
>
>Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
>---
> C4/Circulation.pm |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index f24f2f7..5f7e866 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -928,7 +928,7 @@ sub CanBookBeIssued {
> 
>     if ( $rentalConfirmation ){
>         my ($rentalCharge) = GetIssuingCharges( $item->{'itemnumber'}, $borrower->{'borrowernumber'} );
>-        if ( $rentalCharge ){
>+        if ( $rentalCharge > 0 ){
>             $rentalCharge = sprintf("%.02f", $rentalCharge);
>             $needsconfirmation{RENTALCHARGE} = $rentalCharge;
>         }
>-- 
>1.7.10.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 13461: 34383 | 34415 | 34450