Attachment 34441 Details for Bug 12923 – Bug 12923 - Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output.

[patch] Bug 12923 - Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output.

Bug-12923---Improve-error-logging-for-advancenotic.patch (text/plain), 4.32 KB, created by Olli-Antti Kivilahti on 2014-12-15 16:16:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olli-Antti Kivilahti

Created: 2014-12-15 16:16:41 UTC

Size: 4.32 KB

patch

obsolete

>From 97eb3b9c099ae99136c6ca7f096fd93249d20bf3 Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Mon, 15 Sep 2014 11:42:34 +0300
>Subject: [PATCH] Bug 12923 - Improve error logging for advance_notices.pl;
> Show borrowernumber when no letter of type is found and
> force utf8 output.
>
>when running advance_notices.pl with -n flag, diacritics run awol in the console output!
>
>Also when debugging which borrower requests undefined letter templates, it is very handy to log the
>borrowernumber so we catch and fix bad borrower message transport settings.
>
>This patch fixes those issues.
>
>TEST PREPARATION:
>
>0. Edit the ODUEDGST letter, find an undefined letter for any trasport type.
>
>::TESTS ARE (ALMOST) THE SAME AS IN bugg 12922::
>TEST PLAN:
>
>1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to
>   the undefined digest. Set the "Days in Advance" to 1.
>2. Check-out something for that borrower and set the due date for tomorrow.
>3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
>4. BEFORE THIS PATCH: You get an error
>   "no letter of type 'PREDUEDGST' found. Please see sample_notices.sql at ./advance_notices.pl line 366."
>4. AFTER THIS PATCH: You get an error
>   "no letter of type 'PREDUEDGST' found for borrowernumber 1104659. Please see sample_notices.sql at
>   ./advance_notices.pl line 368."
>   Makes life more worth living for!
>   Also diacritics printed on screen are displayed properly.
>---
> misc/cronjobs/advance_notices.pl |   10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl
>index 26f87ae..5581b8d 100755
>--- a/misc/cronjobs/advance_notices.pl
>+++ b/misc/cronjobs/advance_notices.pl
>@@ -161,6 +161,8 @@ The F<misc/cronjobs/overdue_notices.pl> program allows you to send
> messages to patrons when their messages are overdue.
> =cut
> 
>+binmode( STDOUT, ':encoding(UTF-8)' );
>+
> # These are defaults for command line options.
> my $confirm;                                                        # -c: Confirm that the user has read and configured this script.
> my $nomail;                                                         # -n: No mail. Will not send any emails.
>@@ -265,7 +267,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
>                                       substitute     => { 'items.content' => $titles },
>                                       message_transport_type => $transport,
>                                     } )
>-                    or warn "no letter of type '$letter_type' found. Please see sample_notices.sql";
>+                    or warn "no letter of type '$letter_type' found for borrowernumber ".$upcoming->{'borrowernumber'}.". Please see sample_notices.sql";
>                 push @letters, $letter if $letter;
>             }
>         }
>@@ -301,7 +303,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
>                                       substitute     => { 'items.content' => $titles },
>                                       message_transport_type => $transport,
>                                     } )
>-                    or warn "no letter of type '$letter_type' found. Please see sample_notices.sql";
>+                    or warn "no letter of type '$letter_type' found for borrowernumber ".$upcoming->{'borrowernumber'}.". Please see sample_notices.sql";
>                 push @letters, $letter if $letter;
>             }
>         }
>@@ -376,7 +378,7 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$upcoming_digest ) {
>                 message_transport_type => $transport,
>             }
>           )
>-          or warn "no letter of type '$letter_type' found. Please see sample_notices.sql";
>+          or warn "no letter of type '$letter_type' found for borrowernumber $borrowernumber. Please see sample_notices.sql";
>         push @letters, $letter if $letter;
>     }
> 
>@@ -434,7 +436,7 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$due_digest ) {
>                 message_transport_type => $transport,
>             }
>           )
>-          or warn "no letter of type '$letter_type' found. Please see sample_notices.sql";
>+          or warn "no letter of type '$letter_type' found for borrowernumber $borrowernumber. Please see sample_notices.sql";
>         push @letters, $letter if $letter;
>     }
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12923: 31615 | 34441 | 44688 | 45321