Bugzilla – Attachment 34479 Details for
Bug 13468
overdue notice lists all checked out books
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
BUG 13468: Overdue notice lists all checked out books
BUG-13468-Overdue-notice-lists-all-checked-out-boo.patch (text/plain), 1.66 KB, created by
Jonathan Druart
on 2014-12-17 10:08:53 UTC
(
hide
)
Description:
BUG 13468: Overdue notice lists all checked out books
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-12-17 10:08:53 UTC
Size:
1.66 KB
patch
obsolete
>From 054587e0ca9ed966d99bd437a7992662db228e25 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 16 Dec 2014 17:15:58 +0000 >Subject: [PATCH] BUG 13468: Overdue notice lists all checked out books > >This patch should fix the issue when running under 'triggered' mode > >To test: > >1) Run overdue_notices.pl -t -n [to output notices to command >line] >2) Note that the notices output, list ALL checked out items >3) Apply Patch >4) Run again >5) Note the difference > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Amended patch: remove space changes. >--- > misc/cronjobs/overdue_notices.pl | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 4e58e8a..4d05ff7 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -621,8 +621,17 @@ END_SQL > } > } > else { >- unless ($days_between >=$mindays && $days_between <= $maxdays){ >- next; >+ if ($triggered) { >+ if ( $mindays != $days_between ) { >+ next; >+ } >+ } >+ else { >+ unless ( $days_between >= $mindays >+ && $days_between <= $maxdays ) >+ { >+ next; >+ } > } > } > >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13468
:
34466
|
34473
| 34479