Bugzilla – Attachment 34550 Details for
Bug 11814
Serial statuses should be stored in constants
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11814: Fix existing tests
Bug-11814-Fix-existing-tests.patch (text/plain), 1.40 KB, created by
Jonathan Druart
on 2014-12-19 14:49:30 UTC
(
hide
)
Description:
Bug 11814: Fix existing tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-12-19 14:49:30 UTC
Size:
1.40 KB
patch
obsolete
>From 8ec70fe3600c8c111658e0a2ee55c00b85e20286 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 19 Dec 2014 15:48:49 +0100 >Subject: [PATCH] Bug 11814: Fix existing tests > >--- > C4/Serials.pm | 2 +- > t/db_dependent/Serials.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 6542d7e..fe0d0b0 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -852,7 +852,7 @@ this function returns every serial waited for a given subscription > as well as the number of issues registered in the database (all types) > this number is used to see if a subscription can be deleted (=it must have only 1 issue) > >-$statuses is an arrayref of statuses. >+$statuses is an arrayref of statuses and is mandatory. > > =cut > >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index 8fbb709..62ff86d 100644 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -210,7 +210,7 @@ my @statuses = qw( 2 2 3 3 3 3 3 4 4 41 42 43 44 5 ); > my $counter = 0; > for my $status ( @statuses ) { > my $serialseq = "No.".$counter; >- my ( $expected_serial ) = GetSerials2( $subscriptionid, 1 ); >+ my ( $expected_serial ) = GetSerials2( $subscriptionid, [1] ); > C4::Serials::ModSerialStatus( $expected_serial->{serialid}, $serialseq, $publisheddate, $publisheddate, $statuses[$counter], 'an useless note' ); > $counter++; > } >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11814
:
25541
|
25542
|
27605
|
33512
|
33513
|
33514
|
33552
|
33890
|
33990
|
33991
|
33992
|
34550
|
34563
|
34564
|
34565
|
34566
|
34567
|
34568
|
34569
|
34570