Attachment 34559 Details for Bug 11395 – [PASSED QA] Bug 11395: prevent processing no record

[patch] [PASSED QA] Bug 11395: prevent processing no record

PASSED-QA-Bug-11395-prevent-processing-no-record.patch (text/plain), 1.64 KB, created by Kyle M Hall (khall) on 2014-12-19 15:01:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-12-19 15:01:40 UTC

Size: 1.64 KB

patch

obsolete

>From 1a1750c7c019808506e394d087ff18dfbb221a7e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 8 Jul 2014 10:01:31 +0200
>Subject: [PATCH] [PASSED QA] Bug 11395: prevent processing no record
>
>If no record is selected, the modification should not be launched.
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../en/modules/tools/batch_record_modification.tt  |   12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index 9b53c5a..e02bfd8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -41,11 +41,15 @@ $(document).ready(function() {
>   }));
> 
>   $("#mainformsubmit").click(function(){
>-    if ( $("#marc_modification_template_id").val() > 0 ) {
>-      return submitBackgroundJob(document.getElementById("process"));
>+    if ($("input[type=checkbox][name='record_id']:checked").length == 0 ) {
>+      alert(_("Please select at least one record to process"));
>+      return false;
>     }
>-    alert(_("Please select a modification template."));
>-    return false;
>+    if ( $("#marc_modification_template_id").val() <= 0 ) {
>+      alert(_("Please select a modification template."));
>+      return false;
>+    }
>+    return submitBackgroundJob(document.getElementById("process"));
>   });
> 
>   $("#marc_modification_template_id").change(function(){
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11395: 23502 | 23503 | 23504 | 23505 | 23506 | 23507 | 23508 | 23592 | 24634 | 26072 | 26981 | 28978 | 28999 | 29000 | 29001 | 29002 | 29003 | 29004 | 29056 | 29509 | 29569 | 31344 | 32181 | 32182 | 32184 | 32239 | 32240 | 32241 | 32242 | 32243 | 32244 | 32245 | 32246 | 32247 | 32248 | 32249 | 33145 | 33146 | 33147 | 33148 | 33149 | 33150 | 33151 | 33152 | 33153 | 33154 | 33155 | 34393 | 34394 | 34395 | 34396 | 34397 | 34398 | 34399 | 34400 | 34401 | 34402 | 34552 | 34553 | 34554 | 34555 | 34556 | 34557 | 34558 | 34559 | 34560 | 34561 | 34562 | 35783 | 35784 | 35785 | 35786 | 35787 | 35788 | 35789 | 35790 | 35791 | 35792 | 36295 | 36296 | 36297 | 36298 | 36299 | 36300 | 36301 | 36302 | 36303 | 36304