Bugzilla – Attachment 34617 Details for
Bug 13425
There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13425 - XSS in intranet facets - Patch for 3.18 and master
Bug-13425---XSS-in-intranet-facets---Patch-for-318.patch (text/plain), 3.13 KB, created by
Katrin Fischer
on 2014-12-21 20:43:57 UTC
(
hide
)
Description:
Bug 13425 - XSS in intranet facets - Patch for 3.18 and master
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-12-21 20:43:57 UTC
Size:
3.13 KB
patch
obsolete
>From 9548708ed822d5bebd881831c3e673261e1a1a83 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed, 10 Dec 2014 12:47:30 +1300 >Subject: [PATCH] Bug 13425 - XSS in intranet facets - Patch for 3.18 and > master > >To Test >1/ Craft a url like /cgi-bin/koha/catalogue/search.pl?q=smith&sort_by='"><script>prompt('Happy_Holidays')</script> > >It is important it must return results and facets > >2/ Notice the js is executed >3/ Apply the patch test again > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works alright, no regressions found in selecting and undoing facets. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index 97891eb..1de5cee 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -3,7 +3,7 @@ > <div id="search-facets"> > <h4>Refine your search</h4> > <ul> >- <li id="availability_facet">Availability<ul><li>[% IF ( available ) %]Showing only <strong>available</strong> items. <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&sort_by=[% sort_by %][% END %]">Show all items</a>[% ELSE %]Limit to <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by %][% END %]&limit=available">currently available items.</a>[% END %]</li></ul> >+ <li id="availability_facet">Availability<ul><li>[% IF ( available ) %]Showing only <strong>available</strong> items. <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]">Show all items</a>[% ELSE %]Limit to <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]&limit=available">currently available items.</a>[% END %]</li></ul> > [% IF ( related ) %] <li>(related searches: [% FOREACH relate IN related %][% relate.related_search %][% END %])</li>[% END %] > </li> > >@@ -33,10 +33,10 @@ > [% IF facet.active %] > [% SET url = url _ "&nolimit=" _ facet.type_link_value _ ":" _ facet.facet_link_value %] > <span class="facet-label">[% facet.facet_label_value %]</span> >- [<a href="[% url %]" title="Remove facet [% facet.facet_title_value | html %]">x</a>] >+ [<a href="[% url |url%]" title="Remove facet [% facet.facet_title_value | html %]">x</a>] > [% ELSE %] > [% SET url = url _ "&limit=" _ facet.type_link_value _ ":" _ facet.facet_link_value %] >- <span class="facet-label"><a href="[% url %]" title="[% facet.facet_title_value |html %]">[% facet.facet_label_value %]</a></span> >+ <span class="facet-label"><a href="[% url |url%]" title="[% facet.facet_title_value |html %]">[% facet.facet_label_value %]</a></span> > [% IF ( displayFacetCount ) %] > <span class="facet-count"> ([% facet.facet_count %])</span> > [% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13425
:
34255
|
34256
|
34257
|
34258
|
34259
|
34260
|
34261
|
34262
|
34264
|
34265
|
34267
|
34273
|
34389
|
34496
|
34507
|
34603
|
34617
|
34618
|
34619
|
34636