Bugzilla – Attachment 34677 Details for
Bug 11607
items.content does not contain any formatting when HTML message is selected.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11607: Don't display all items in a single line
Bug-11607-Dont-display-all-items-in-a-single-line.patch (text/plain), 1.20 KB, created by
Jonathan Druart
on 2014-12-24 12:13:50 UTC
(
hide
)
Description:
Bug 11607: Don't display all items in a single line
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-12-24 12:13:50 UTC
Size:
1.20 KB
patch
obsolete
>From 5e1b531a62c7d7d9856dc54a85514df6fe58cc7e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 24 Dec 2014 13:09:27 +0100 >Subject: [PATCH] Bug 11607: Don't display all items in a single line > >If the *DGST notices are sent in HTML, the items are displayed in a >single line. > >To reproduce: >1/ Define a *DGST notice using the <<items.content>> pattern. >2/ Checkout at least 2 items to a patron and set the due date as today. >3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. >4/ Verify the email you will receive separates the items with a line >break. > >Verify you don't find a regression for non-html letters. >--- > C4/Letters.pm | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index a11c862..e36c87f 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -620,6 +620,10 @@ sub GetPreparedLetter { > > if ($substitute) { > while ( my ($token, $val) = each %$substitute ) { >+ if ( $token eq 'items.content' ) { >+ $val =~ s|\n|<br/>|g if $letter->{is_html}; >+ } >+ > $letter->{title} =~ s/<<$token>>/$val/g; > $letter->{content} =~ s/<<$token>>/$val/g; > } >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11607
:
34677
|
34688
|
34700