Attachment 34694 Details for Bug 13264 – Bug 13264: (QA followup) prevent double-encoding on the tests

[patch] Bug 13264: (QA followup) prevent double-encoding on the tests

Bug-13264-QA-followup-prevent-double-encoding-on-t.patch (text/plain), 1.72 KB, created by Tomás Cohen Arazi (tcohen) on 2014-12-26 23:54:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2014-12-26 23:54:02 UTC

Size: 1.72 KB

patch

obsolete

>From 2f57e4a6754fd4e27c0fcdad7033306e31b97edf Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Fri, 26 Dec 2014 20:52:54 -0300
>Subject: [PATCH] Bug 13264: (QA followup) prevent double-encoding on the tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>---
> t/db_dependent/www/search_utf8.t | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/www/search_utf8.t b/t/db_dependent/www/search_utf8.t
>index e09a1af..605e21a 100644
>--- a/t/db_dependent/www/search_utf8.t
>+++ b/t/db_dependent/www/search_utf8.t
>@@ -209,12 +209,12 @@ like( $intra_text, qr|Publisher: $publisher|, );
> $agent->get_ok( "$intranet/cgi-bin/koha/catalogue/search.pl" , "got search on intranet");
> $agent->form_number(1);
> $agent->field('idx', 'kw');
>-$agent->field('q', Encode::encode('UTF-8', $publisher));
>+$agent->field('q', $publisher);
> $agent->click();
> $intra_text = $agent->text();
> 
> like( $intra_text, qr|Publisher: $publisher|, );
>-my $expected_base = q|search.pl\?idx=kw&q=| . uri_escape_utf8( Encode::encode('UTF-8', $publisher ) );
>+my $expected_base = q|search.pl\?idx=kw&q=| . uri_escape_utf8( $publisher );
> $agent->base_like(qr|$expected_base|, );
> 
> ok ( ( length(Encode::encode('UTF-8', $intra_text)) != length($intra_text) ) , 'UTF-8 are multi-byte. Goog') ;
>@@ -237,7 +237,7 @@ $agent->click();
> $opac_text = $agent->text();
> 
> like( $opac_text, qr|Publisher: $publisher|, );
>-$expected_base = q|opac-search.pl\?q=| . uri_escape_utf8( $publisher );
>+$expected_base = q|opac-search.pl\?idx=&q=| . uri_escape_utf8( $publisher );
> $agent->base_like(qr|$expected_base|, );
> 
> ok ( ( length(Encode::encode('UTF-8', $opac_text)) != length($opac_text) ) , 'UTF-8 are multi-byte. Goog') ;
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13264: 33614 | 33703 | 33704 | 33705 | 33743 | 33744 | 33756 | 33757 | 33758 | 33759 | 33760 | 33777 | 33778 | 33779 | 33780 | 33781 | 33782 | 33783 | 33784 | 33785 | 33786 | 33811 | 33812 | 33813 | 33814 | 33815 | 33816 | 33817 | 34110 | 34111 | 34112 | 34113 | 34114 | 34115 | 34116 | 34117 | 34694 | 34766 | 34767 | 34768 | 34769 | 34770 | 34771 | 34772 | 34773 | 34774 | 34775 | 34776 | 34798 | 34799 | 34800 | 34801 | 34802 | 34803 | 34804 | 34805 | 34806 | 34807 | 34808 | 34809 | 34810 | 34811 | 34814 | 35068 | 35069 | 35070 | 35071 | 35072 | 35073 | 35074 | 35075 | 35076 | 35077 | 35078 | 35079 | 35080 | 35081 | 35082 | 35110 | 35111 | 35112 | 35113 | 35114 | 35115 | 35116 | 35117 | 35118 | 35119 | 35120 | 35121 | 35122 | 35123 | 35124