Attachment 34699 Details for Bug 13167 – [PASSED QA] Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13

[patch] [PASSED QA] Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13

PASSED-QA-Bug-13167-Stage-MARC-for-Import-hangs-fo.patch (text/plain), 1.57 KB, created by Katrin Fischer on 2014-12-27 10:38:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-12-27 10:38:15 UTC

Size: 1.57 KB

patch

obsolete

>From ab01f6169282c726e5ebca58a225d245759d1c4f Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Sun, 2 Nov 2014 17:41:34 +0100
>Subject: [PATCH] [PASSED QA] Bug 13167 Stage MARC for Import hangs for biblio
> containing invalid ISBN-13
>
>If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for
>import' hangs.  If I use the same UNIMARC record and change 979 to 978 in the
>ISBN, 'Stage MARC for import' works perfectly.
>
>The patch deals with the fact that converting an ISBN-13 to ISBN-10 with
>Business::ISBN as_isbn10() method fails if the ISBN doesn't begin with 978.
>
>TEST PLAN:
>
>(1) Download, and decompress the ZIP file attached to BZ.
>(2) On a UNIMARC Koha instance, go in Tools > Stage MARC for import.
>(3) Choose the MARC file containing the record with an ISBN begining with 979.
>    Click on Upload file, then Stage to import.
>(4) The Job progress bar stay at 0%.
>(5) Apply the patch. Repeat steps 2-3. The upload works.
>
>Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Tested in a UNIMARC installation, confirmed that the patch fixes the
>problem.
>---
> C4/Koha.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index 1b6160a..ec65be9 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -1680,6 +1680,7 @@ sub NormalizeISBN {
>         elsif ( $format eq 'ISBN-13' ) {
>             $isbn = $isbn->as_isbn13();
>         }
>+        return unless $isbn;
> 
>         if ($strip_hyphens) {
>             $string = $isbn->as_string( [] );
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13167: 32969 | 33130 | 34414 | 34699 | 34916 | 34917