Bugzilla – Attachment 34725 Details for
Bug 13124
Record titles with parentheses causing label weirdness
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13124 - Record titles with parentheses causing label weirdness
PASSED-QA-Bug-13124---Record-titles-with-parenthes.patch (text/plain), 1.83 KB, created by
Katrin Fischer
on 2014-12-27 15:59:28 UTC
(
hide
)
Description:
[PASSED QA] Bug 13124 - Record titles with parentheses causing label weirdness
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-12-27 15:59:28 UTC
Size:
1.83 KB
patch
obsolete
>From 04df34d98a279c60363d323e75d032ec5d0b4716 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 21 Oct 2014 06:18:29 -0400 >Subject: [PATCH] [PASSED QA] Bug 13124 - Record titles with parentheses > causing label weirdness > >Test Plan ( using sample data included with Koha ) >1) Catalog a record and item with the title "Oh no! or, (How my > science project destroyed the world) /" >2) Edit the DEFAULT template > a) Set layout type to Biblio > b) Set data fields to "title, author, isbn, issn, itemtype, > barcode, itemcallnumber" > c) Set font size to 10 >3) Create a batch with just the one item you created >4) Export the PDF with the Avery template and the DEFAULT layout >5) Note the weirdness >6) Apply this patch >7) Re-export the PDF, note it's no longer weird ; ) > >Signed-off-by: Nick Clemens <nick@quecheelibrary.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Labels/Label.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Labels/Label.pm b/C4/Labels/Label.pm >index ff6c865..bd3ee4f 100644 >--- a/C4/Labels/Label.pm >+++ b/C4/Labels/Label.pm >@@ -424,8 +424,9 @@ sub draw_label_text { > else { > if ($field_data) { > $field_data =~ s/\/$//g; # Here we will strip out all trailing '/' in fields other than the call number... >- $field_data =~ s/\(/\\\(/g; # Escape '(' and ')' for the pdf object stream... >- $field_data =~ s/\)/\\\)/g; >+ # Escaping the parens was causing odd output, see bug 13124 >+ # $field_data =~ s/\(/\\\(/g; # Escape '(' and ')' for the pdf object stream... >+ # $field_data =~ s/\)/\\\)/g; > } > eval{$Text::Wrap::columns = $self->{'text_wrap_cols'};}; > my @line = split(/\n/ ,wrap('', '', $field_data)); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13124
:
32563
|
32564
|
32565
|
32566
|
34337
| 34725