Attachment 34740 Details for Bug 13268 – Bug 13268 - biblioitems.size value not correctly displayed (more)

[patch] Bug 13268 - biblioitems.size value not correctly displayed (more)

Bug-13268---biblioitemssize-value-not-correctly-di.patch (text/plain), 5.79 KB, created by Chris Cormack on 2014-12-28 04:47:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2014-12-28 04:47:38 UTC

Size: 5.79 KB

patch

obsolete

>From b29236f75c979375703878aed2dfe2a9fee68c81 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 17 Nov 2014 16:32:20 +0100
>Subject: [PATCH] Bug 13268 - biblioitems.size value not correctly displayed
> (more)
>
>Bug partially corrected by Bug 11357.
>
>The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop.
>
>It's currently used in the templates like opac-topissues.tt :
>[% IF results_loo.size %][% results_loo.size %][% END %]
>
>This patch corrects by using item() TT method.
>See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template.
>
>Test plan :
>- Be sure there is a mapping between a MARC field and biblioitems.size
>- Create a record A with biblioitems.size defined : like "10x12"
>- Create a record B with no value in biblioitems.size
>- Check each modified page :
>=> Without this patch : you see a number (loop size) for both records
>=> With this patch : you only see the correct value for A and nothing for B
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>index 39d9937..5619816 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>@@ -121,7 +121,7 @@
> [% IF ( resultsloo.edition ) %]Edition: [% resultsloo.edition %][% END %]
> [% IF ( resultsloo.place ) %] ; [% resultsloo.place %][% END %]
> [% IF ( resultsloo.pages ) %] - [% resultsloo.pages %][% END %]
>- [% IF ( resultsloo.size ) %] ; [% resultsloo.size %][% END %]
>+ [% IF ( resultsloo.item('size') ) %] ; [% resultsloo.item('size') %][% END %]
> [% IF ( resultsloo.timestamp ) %] (modified on [% resultsloo.timestamp %])[% END %]
> 
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index b247706..6dced76 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -73,7 +73,7 @@ $(document).ready(function() {
> [% IF ( itemsloo.publicationyear ) %], [% itemsloo.publicationyear %]
> [% ELSIF ( itemsloo.copyrightdate ) %], [% itemsloo.copyrightdate %][% END %]
> [% IF ( itemsloo.pages ) %]: [% itemsloo.pages %] [% END %]
>- [% IF ( itemsloo.size ) %][% itemsloo.size %][% END %] [% IF ( itemsloo.isbn ) %]ISBN: [% itemsloo.isbn %][% END %]
>+ [% IF ( itemsloo.item('size') ) %][% itemsloo.item('size') %][% END %] [% IF ( itemsloo.isbn ) %]ISBN: [% itemsloo.isbn %][% END %]
> 			</div>
> 			</td>
> <td class="hq-collection">[% AuthorisedValues.GetByCode( 'CCODE', itemsloo.ccode ) %]</td>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index f39b2c5..6f4a1c9 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -381,7 +381,7 @@
> [% END %]
> [% IF ( itemsloo.pages ) %]. [% itemsloo.pages %][% END %]
> [% IF ( itemsloo.notes ) %], [% itemsloo.notes|html %][% END %]
>- [% IF ( itemsloo.size ) %] [% itemsloo.size %][% END %]
>+ [% IF ( itemsloo.item('size') ) %] [% itemsloo.item('size') %][% END %]
> 
> 
> Holdings:
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
>index fd21332..26c52cf 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
>@@ -72,7 +72,7 @@
> [% results_loo.copyrightdate %]
> [% END %]
> [% IF ( results_loo.pages ) %] - [% results_loo.pages %][% END %]
>- [% IF ( results_loo.size ) %][% results_loo.size %][% END %]
>+ [% IF ( results_loo.item('size') ) %][% results_loo.item('size') %][% END %]
> </td>
> <td>
> [% IF ( results_loo.description ) %]
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13268: 33615 | 34286 | 34287 | 34740 | 34741 | 34757 | 34758