Bugzilla – Attachment 34821 Details for
Bug 1861
Unique patrons logins not (totally) enforced
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 1861 [SIGNED OFF]: There is a problem introduced with an earlier patch, on this patchset
Bug-1861-SIGNED-OFF-There-is-a-problem-introduced-.patch (text/plain), 1.78 KB, created by
Martin Renvoize (ashimema)
on 2014-12-30 08:04:56 UTC
(
hide
)
Description:
Bug 1861 [SIGNED OFF]: There is a problem introduced with an earlier patch, on this patchset
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2014-12-30 08:04:56 UTC
Size:
1.78 KB
patch
obsolete
>From 32aeb82aa2d0956956929f21eb76f7cbd71be9e7 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Tue, 30 Dec 2014 15:37:39 +1300 >Subject: [PATCH] Bug 1861 [SIGNED OFF]: There is a problem introduced with an > earlier patch, on this patchset > >- $data{'userid'} = Generate_Userid($data{'borrowernumber'}, >$data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; >+ $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, >$data{'firstname'}, $data{'surname'} ) >+ if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); > >Check_Userid returns 1 if it is unique. So this means unique userids >will always be discarded and new ones created. > >This is why all the tests depending on a userid are now failing > >To test > >1/ run perl t/db_dependent/Serials_2.t >2/ Notice lots of tests fail >3/ OR Add a borrower with a userid set, notice the userid is ignored >and one is generated instead >4/ Apply patch >5/ Add a new borrower, notice the userid sticks (if it is unique) >6/ Run perl t/db_dependent/Serials_2.t notice tests pass >7/ Run perl t/db_dependent/Members.t notice tests still pass > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index 1611991..e1449df 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -856,7 +856,7 @@ sub AddMember { > > # generate a proper login if none provided > $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) >- if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); >+ if ( $data{'userid'} eq '' || !Check_Userid( $data{'userid'} ) ); > > # add expiration date if it isn't already there > unless ( $data{'dateexpiry'} ) { >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 1861
:
29573
|
29616
|
30561
|
30828
|
33143
|
33144
|
33749
|
33750
|
33751
|
33752
|
33983
|
33984
|
33985
|
34820
|
34821
|
34822
|
34823