Attachment 34882 Details for Bug 11023 – Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to "automatic item modification by age"

[patch] Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to "automatic item modification by age"

Bug-11023-QA-Followup---Complete-the-renaming-of-t.patch (text/plain), 9.83 KB, created by Kyle M Hall (khall) on 2015-01-02 14:09:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-01-02 14:09:49 UTC

Size: 9.83 KB

patch

obsolete

>From 57c23f34f160bd29348f404ccf50b634d8f1cf40 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 1 Jan 2015 18:13:04 -0500
>Subject: [PATCH] Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to "automatic item modification by age"
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> installer/data/mysql/kohastructure.sql             |    4 ++--
> .../intranet-tmpl/prog/en/css/staff-global.css     |    2 +-
> .../en/modules/help/tools/toggle_new_status.tt     |    2 +-
> ...us.tt => automatic_item_modification_by_age.tt} |   10 +++++-----
> .../prog/en/modules/tools/tools-home.tt            |    2 +-
> .../cronjobs/automatic_item_modification_by_age.pl |    6 +++---
> ...ewStatus.t => AutomaticItemModificationByAge.t} |    0
> ...us.pl => automatic_item_modification_by_age.pl} |    6 +++---
> 8 files changed, 16 insertions(+), 16 deletions(-)
> rename koha-tmpl/intranet-tmpl/prog/en/modules/tools/{toggle_new_status.tt => automatic_item_modification_by_age.tt} (95%)
> rename t/db_dependent/Items/{ToggleNewStatus.t => AutomaticItemModificationByAge.t} (100%)
> rename tools/{toggle_new_status.pl => automatic_item_modification_by_age.pl} (94%)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 9f68322..691dc64 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -946,7 +946,7 @@ CREATE TABLE `deleteditems` (
>   `enumchron` text default NULL, -- serial enumeration/chronology for the item (MARC21 952$h)
>   `copynumber` varchar(32) default NULL, -- copy number (MARC21 952$t)
>   `stocknumber` varchar(32) default NULL, -- inventory number (MARC21 952$i)
>-  `new` VARCHAR(32) DEFAULT NULL, -- 'new' value, you can put whatever free-text information. This field is intented to be managed by the toggle_new_status cronjob.
>+  `new` VARCHAR(32) DEFAULT NULL, -- 'new' value, you can put whatever free-text information. This field is intented to be managed by the automatic_item_modification_by_age cronjob.
>   PRIMARY KEY  (`itemnumber`),
>   KEY `delitembarcodeidx` (`barcode`),
>   KEY `delitemstocknumberidx` (`stocknumber`),
>@@ -1246,7 +1246,7 @@ CREATE TABLE `items` ( -- holdings/item information
>   `enumchron` text default NULL, -- serial enumeration/chronology for the item (MARC21 952$h)
>   `copynumber` varchar(32) default NULL, -- copy number (MARC21 952$t)
>   `stocknumber` varchar(32) default NULL, -- inventory number (MARC21 952$i)
>-  `new` VARCHAR(32) DEFAULT NULL, -- 'new' value, you can put whatever free-text information. This field is intended to be managed by the toggle_new_status cronjob.
>+  `new` VARCHAR(32) DEFAULT NULL, -- 'new' value, you can put whatever free-text information. This field is intended to be managed by the automatic_item_modification_by_age cronjob.
>   PRIMARY KEY  (`itemnumber`),
>   UNIQUE KEY `itembarcodeidx` (`barcode`),
>   KEY `itemstocknumberidx` (`stocknumber`),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index 9e50d0e..bf558ba 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -2759,7 +2759,7 @@ span.onsite_checkout {
>     border : 1px solid #FFF2CE;
> }
> 
>-/* Tools > toggle_new_status */
>+/* Tools > automatic_item_modification_by_age */
> div.rules {
>     display: block;
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/toggle_new_status.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/toggle_new_status.tt
>index 0bb591f..292703a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/toggle_new_status.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/toggle_new_status.tt
>@@ -38,7 +38,7 @@
> </ul>
> 
> <h3>How to execute the cronjob script?</h3>
>-<p>The cronjob script is misc/cronjobs/toggle_new_status.pl.</p>
>+<p>The cronjob script is misc/cronjobs/automatic_item_modification_by_age.pl.</p>
> <p>Try the -h parameter in order to see the help.</p>
> <p>Without any parameter, the script will be launched in a dry-run mode. If the -c (or --confirm) flag is given, the script will apply the changes.</p>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
>similarity index 95%
>rename from koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt
>rename to koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
>index 86f47b4..a08e96d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/toggle_new_status.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
>@@ -113,10 +113,10 @@
> //]]>
> </script>
> </head>
>-<body id="tools_toggle_new_status" class="tools">
>+<body id="tools_automatic_item_modification_by_age" class="tools">
> [% INCLUDE 'header.inc' %]
> [% INCLUDE 'cat-search.inc' %]
>-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo; <a href="/cgi-bin/koha/tools/toggle_new_status.pl">Automatic item modifications by age</a></div>
>+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo; <a href="/cgi-bin/koha/tools/automatic_item_modification_by_age.pl">Automatic item modifications by age</a></div>
> 
> <div id="doc3" class="yui-t2">
>   <div id="bd">
>@@ -124,7 +124,7 @@
>       <div class="yui-b">
>         <h3>Automatic item modifications by age</h3>
>         <div id="toolbar" class="btn-toolbar">
>-          <a class="btn btn-small" id="newentry" href="/cgi-bin/koha/tools/toggle_new_status.pl?op=edit_form"><i class="icon-plus"></i> Edit</a>
>+          <a class="btn btn-small" id="newentry" href="/cgi-bin/koha/tools/automatic_item_modification_by_age.pl?op=edit_form"><i class="icon-plus"></i> Edit</a>
>         </div>
>         [% FOR message IN messages %]
>           [% IF message.type == "error" %]
>@@ -137,7 +137,7 @@
>         [% END %]
> 
>         [% IF op == 'edit_form' %]
>-          <form method="post" action="/cgi-bin/koha/tools/toggle_new_status.pl">
>+          <form method="post" action="/cgi-bin/koha/tools/automatic_item_modification_by_age.pl">
>             <div id="edit_rules">
>               <h4>List of rules</h4>
>                 <div id="rules">
>@@ -200,7 +200,7 @@
>                 </div>
>               <fieldset class="action">
>                 <input type="hidden" name="op" value="update" />
>-                <a class="cancel" href="/cgi-bin/koha/tools/toggle_new_status.pl">Cancel</a>
>+                <a class="cancel" href="/cgi-bin/koha/tools/automatic_item_modification_by_age.pl">Cancel</a>
>                 <input type="submit" value="Submit theses rules" />
>               </fieldset>
>             </div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>index bac4510..146eb11 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>@@ -128,7 +128,7 @@
>     [% END %]
> 
>     [% IF ( CAN_user_tools_items_batchmod ) %]
>-      <dt><a href="/cgi-bin/koha/tools/toggle_new_status.pl">Automatic item modifications by age</a></dt>
>+      <dt><a href="/cgi-bin/koha/tools/automatic_item_modification_by_age.pl">Automatic item modifications by age</a></dt>
>       <dd>Define rules to modify items by age</dd>
>     [% END %]
> 
>diff --git a/misc/cronjobs/automatic_item_modification_by_age.pl b/misc/cronjobs/automatic_item_modification_by_age.pl
>index 3ed3e46..51effd3 100755
>--- a/misc/cronjobs/automatic_item_modification_by_age.pl
>+++ b/misc/cronjobs/automatic_item_modification_by_age.pl
>@@ -21,7 +21,7 @@ pod2usage(1) if $help;
> $verbose = 1 unless $confirm;
> 
> # Load configuration from the syspref
>-my $syspref_content = C4::Context->preference('toggle_new_status_configuration');
>+my $syspref_content = C4::Context->preference('automatic_item_modification_by_age_configuration');
> my $rules = eval { JSON::from_json( $syspref_content ) };
> pod2usage({ -message => "Unable to load the configuration : $@", -exitval => 1 })
>     if $@;
>@@ -51,11 +51,11 @@ __END__
> 
> =head1 NAME
> 
>-toggle_new_status.pl
>+automatic_item_modification_by_age.pl
> 
> =head1 SYNOPSIS
> 
>-./toggle_new_status.pl -h
>+./automatic_item_modification_by_age.pl -h
> 
> Toggle recent acquisitions status.
> Use this script to delete "new" status for items.
>diff --git a/t/db_dependent/Items/ToggleNewStatus.t b/t/db_dependent/Items/AutomaticItemModificationByAge.t
>similarity index 100%
>rename from t/db_dependent/Items/ToggleNewStatus.t
>rename to t/db_dependent/Items/AutomaticItemModificationByAge.t
>diff --git a/tools/toggle_new_status.pl b/tools/automatic_item_modification_by_age.pl
>similarity index 94%
>rename from tools/toggle_new_status.pl
>rename to tools/automatic_item_modification_by_age.pl
>index 9d4c590..eca339c 100755
>--- a/tools/toggle_new_status.pl
>+++ b/tools/automatic_item_modification_by_age.pl
>@@ -19,7 +19,7 @@
> 
> =head1 NAME
> 
>-toggle_new_status.pl: Update new status for items.
>+automatic_item_modification_by_age.pl: Update new status for items.
> 
> =cut
> 
>@@ -45,7 +45,7 @@ my $cgi = new CGI;
> # open template
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {
>-        template_name   => "tools/toggle_new_status.tt",
>+        template_name   => "tools/automatic_item_modification_by_age.tt",
>         query           => $cgi,
>         type            => "intranet",
>         authnotrequired => 0,
>@@ -55,7 +55,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
> 
> my $op = $cgi->param('op') // 'show';
> 
>-my $syspref_name = q|toggle_new_status_configuration|;
>+my $syspref_name = q|automatic_item_modification_by_age_configuration|;
> if ( $op eq 'update' ) {
>     my @rules;
>     my @unique_ids = $cgi->param('unique_id');
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11023: 21926 | 21932 | 21982 | 21983 | 22004 | 22386 | 22734 | 22735 | 24068 | 24069 | 24070 | 24146 | 24147 | 24148 | 25767 | 25833 | 26817 | 26818 | 26819 | 26820 | 26821 | 26822 | 26855 | 27810 | 29216 | 29217 | 29218 | 29219 | 29220 | 29221 | 29222 | 31820 | 31821 | 31822 | 33226 | 33227 | 33228 | 33229 | 33230 | 33231 | 33232 | 33233 | 33234 | 33235 | 34782 | 34783 | 34784 | 34785 | 34786 | 34787 | 34788 | 34789 | 34790 | 34791 | 34870 | 34871 | 34872 | 34873 | 34874 | 34875 | 34876 | 34877 | 34878 | 34879 | 34880 | 34881 | 34882 | 34883 | 35375 | 35376 | 41147 | 41148