Attachment 34932 Details for Bug 13510 – [PASSED QA] Bug 13510 : Fixing the third XSS issue

[patch] [PASSED QA] Bug 13510 : Fixing the third XSS issue

Bug-13510--Fixing-the-third-XSS-issue.patch (text/plain), 1.59 KB, created by Martin Renvoize (ashimema) on 2015-01-05 08:47:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2015-01-05 08:47:13 UTC

Size: 1.59 KB

patch

obsolete

>From 44487ddf67510f19967901f7eb4fd0ef4928d2b2 Mon Sep 17 00:00:00 2001
>From: Chris <chris@bigballofwax.co.nz>
>Date: Mon, 5 Jan 2015 06:37:51 +0000
>Subject: [PATCH] Bug 13510 : Fixing the third XSS issue
>
>To test
>
>1/ Make sure you have some items in your database, that have values in items.issue
>If nessecary do something like
>
>UPDATE items SET issues = 10 WHERE itemnumber=somenumber
>
>2/ Hit a url like http://localhost:8080/cgi-bin/koha/opac-topissues.pl?do_it=1&timeLimit=3%3Cscript%3Eprompt%28924513%29%3C/script%3E
>
>3/ Notice you will get a prompt
>4/ Apply patch
>5/ Test again
>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
>index fd21332..72f8abd 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
>@@ -49,7 +49,7 @@
>                                     [% branch %]
>                                     [% END %]
>                                     [% IF ( timeLimitFinite ) %]
>-                                    in the past [% timeLimitFinite %] months
>+                                    in the past [% timeLimitFinite |html %] months
>                                     [% ELSE %] of all time[% END %]
>                                 </caption>
>                                 <thead>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13510: 34921 | 34925 | 34926 | 34927 | 34928 | 34929 | 34930 | 34931 | 34932