Bugzilla – Attachment 34954 Details for
Bug 13516
Display issue for search results with items both checkout out and lost
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13516 - Tidy relevant code black
Bug-13516---Tidy-relevant-code-black.patch (text/plain), 2.81 KB, created by
Kyle M Hall (khall)
on 2015-01-05 15:14:24 UTC
(
hide
)
Description:
Bug 13516 - Tidy relevant code black
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-01-05 15:14:24 UTC
Size:
2.81 KB
patch
obsolete
>From 5f2495d3c0da2e9548fc96a06e80efb2184dd1dd Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 5 Jan 2015 10:05:48 -0500 >Subject: [PATCH] Bug 13516 - Tidy relevant code black > >--- > C4/Search.pm | 25 +++++++++++++++---------- > 1 files changed, 15 insertions(+), 10 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 1326f69..0b83466 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -2096,21 +2096,26 @@ sub searchResults { > my $prefix = $item->{$hbranch} . '--' . $item->{location} . $item->{itype} . $item->{itemcallnumber}; > # For each grouping of items (onloan, available, unavailable), we build a key to store relevant info about that item > my $userenv = C4::Context->userenv; >- if ( $item->{onloan} && !(C4::Members::GetHideLostItemsPreference($userenv->{'number'}) && $item->{itemlost}) ) { >+ if ( $item->{onloan} >+ && !( C4::Members::GetHideLostItemsPreference( $userenv->{'number'} ) && $item->{itemlost} ) ) >+ { > $onloan_count++; >- my $key = $prefix . $item->{onloan} . $item->{barcode}; >- $onloan_items->{$key}->{due_date} = format_date($item->{onloan}); >- $onloan_items->{$key}->{count}++ if $item->{$hbranch}; >- $onloan_items->{$key}->{branchname} = $item->{branchname}; >- $onloan_items->{$key}->{location} = $shelflocations->{ $item->{location} }; >- $onloan_items->{$key}->{itemcallnumber} = $item->{itemcallnumber}; >- $onloan_items->{$key}->{description} = $item->{description}; >- $onloan_items->{$key}->{imageurl} = getitemtypeimagelocation( $search_context, $itemtypes{ $item->{itype} }->{imageurl} ); >+ my $key = $prefix . $item->{onloan} . $item->{barcode}; >+ $onloan_items->{$key}->{due_date} = format_date( $item->{onloan} ); >+ $onloan_items->{$key}->{count}++ if $item->{$hbranch}; >+ $onloan_items->{$key}->{branchname} = $item->{branchname}; >+ $onloan_items->{$key}->{location} = $shelflocations->{ $item->{location} }; >+ $onloan_items->{$key}->{itemcallnumber} = $item->{itemcallnumber}; >+ $onloan_items->{$key}->{description} = $item->{description}; >+ $onloan_items->{$key}->{imageurl} = >+ getitemtypeimagelocation( $search_context, $itemtypes{ $item->{itype} }->{imageurl} ); >+ > # if something's checked out and lost, mark it as 'long overdue' > if ( $item->{itemlost} ) { > $onloan_items->{$prefix}->{longoverdue}++; > $longoverdue_count++; >- } else { # can place holds as long as item isn't lost >+ } >+ else { # can place holds as long as item isn't lost > $can_place_holds = 1; > } > } >-- >1.7.2.5
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=34954">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13516
:
34954
|
34955
|
34956
|
34957
|
35097
|
35098
|
38776
|
38777
|
38778