Attachment 34955 Details for Bug 13516 – Bug 13516 - Display issue for search results with items both checkout out and lost

[patch] Bug 13516 - Display issue for search results with items both checkout out and lost

Bug-13516---Display-issue-for-search-results-with-.patch (text/plain), 1.47 KB, created by Kyle M Hall (khall) on 2015-01-05 15:14:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-01-05 15:14:31 UTC

Size: 1.47 KB

patch

obsolete

>From 605b0056721491b19c6a1ee8c44e7c46828d10ab Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 5 Jan 2015 10:10:57 -0500
>Subject: [PATCH] Bug 13516 - Display issue for search results with items both checkout out and lost
>
>If the staff search results, if an item is both checked out and lost,
>the result will appear as two item lines where one line has the lost
>status and the other line has the rest of the item's data.
>
>Test Plan:
>1) Check an item out to a patron
>2) Mark the item as lost *without* removing the item from the patron's
>   record, either by using longoverdue.pl or by editing the itemlost
>   field in the database directly.
>3) Perform a search where that item will be in the results
>4) Note the improper display of the item's data
>5) Apply this patch set
>6) Reload the search restults
>7) Note the item now displays correctly
>---
> C4/Search.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index 0b83466..c40fc9a 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -2112,7 +2112,7 @@ sub searchResults {
> 
>                 # if something's checked out and lost, mark it as 'long overdue'
>                 if ( $item->{itemlost} ) {
>-                    $onloan_items->{$prefix}->{longoverdue}++;
>+                    $onloan_items->{$key}->{longoverdue}++;
>                     $longoverdue_count++;
>                 }
>                 else {    # can place holds as long as item isn't lost
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13516: 34954 | 34955 | 34956 | 34957 | 35097 | 35098 | 38776 | 38777 | 38778