Bugzilla – Attachment 34972 Details for
Bug 12976
Refactor VAT and price calculation - invoice page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12976: Fix some comment in tests
PASSED-QA-Bug-12976-Fix-some-comment-in-tests.patch (text/plain), 2.17 KB, created by
Katrin Fischer
on 2015-01-05 23:24:09 UTC
(
hide
)
Description:
[PASSED QA] Bug 12976: Fix some comment in tests
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-01-05 23:24:09 UTC
Size:
2.17 KB
patch
obsolete
>From bbe5699c4581cdae723c4358ac5a773cd7a6dc6a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 17 Nov 2014 12:45:22 +0100 >Subject: [PATCH] [PASSED QA] Bug 12976: Fix some comment in tests > >Previous comments were wrong. >Actually the main part of price values is correct. >Only some rounding and tax values are badly calculated. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Acquisition.pm | 2 -- > t/Prices.t | 8 +++----- > 2 files changed, 3 insertions(+), 7 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 13785e1..71cdae2 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -2940,8 +2940,6 @@ sub populate_order_with_prices { > } > > if ($receiving) { >- # The following is completely wrong. Will be fixed later. >- # See the unit tests to know what is wrong. > if ( $bookseller->{listincgst} ) { > $order->{unitpricegsti} = Koha::Number::Price->new( $order->{unitprice} )->round; > $order->{unitpricegste} = Koha::Number::Price->new( >diff --git a/t/Prices.t b/t/Prices.t >index 13ce0a7..5d352fa 100644 >--- a/t/Prices.t >+++ b/t/Prices.t >@@ -118,9 +118,8 @@ for my $currency_format ( qw( US FR ) ) { > receiving => 1, > } > ); >- # Note that this configuration is *not* correct! >- # unitpricegsti should be 75.28 >- # totalgst should be 150.56 >+ >+ # Note that this configuration is correct \o/ > compare( > { > got => $order_0_0->{unitpricegsti}, >@@ -341,6 +340,7 @@ for my $currency_format ( qw( US FR ) ) { > > # Note that this configuration is *not* correct! > # rrp gsti should be 82 (what we inserted!) >+ # => Actually we need to fix the inserted value (here we have 82.01 in DB) > # gstvalue should be 7.03 instead of 7.02 > > compare( >@@ -408,8 +408,6 @@ for my $currency_format ( qw( US FR ) ) { > } > ); > # Note that this configuration is *not* correct! >- # unitpricegsti should be 71.69 >- # totalgsti should be 143.38 > # gstvalue should be 7.03 > compare( > { >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12976
:
31812
|
31823
|
31880
|
31983
|
33573
|
33612
|
33613
|
34933
|
34934
|
34935
|
34969
|
34970
|
34971
| 34972