Bugzilla – Attachment 34994 Details for
Bug 9351
item type not recorded correctly in statistics for returns and some local use
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use
SIGNED-OFF-Bug-9351---item-type-not-recorded-corre.patch (text/plain), 1.84 KB, created by
Kyle M Hall (khall)
on 2015-01-07 12:04:52 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-01-07 12:04:52 UTC
Size:
1.84 KB
patch
obsolete
>From 008d89fd22485e620e841c0e436dbb019a1ceed2 Mon Sep 17 00:00:00 2001 >From: Fridolin SOMERS <fridolin.somers@biblibre.com> >Date: Thu, 19 Dec 2013 17:52:25 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use > >When returning a loan, or when returning an item for local use, the corresponding entry in the statistics table takes the item type from the bib level. This is incorrect when item-level item types is enabled. > >This patch corrects this problem by getting itemtype from $item->{'itype'} which comes from item or biblio level in GetItem(). > >Test plan : >- On a catalogue with itemtype on item level, perform a return an look at statistics table >- Idem for a catalogue with itemtype on biblio level > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Circulation.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 5cd8ba3..9901420 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -747,7 +747,7 @@ sub CanBookBeIssued { > branch => C4::Context->userenv->{'branch'}, > type => 'localuse', > itemnumber => $item->{'itemnumber'}, >- itemtype => $item->{'itemtype'}, >+ itemtype => $item->{'itype'}, > borrowernumber => $borrower->{'borrowernumber'}, > ccode => $item->{'ccode'}} > ); >@@ -1988,7 +1988,7 @@ sub AddReturn { > branch => $branch, > type => $stat_type, > itemnumber => $item->{'itemnumber'}, >- itemtype => $biblio->{'itemtype'}, >+ itemtype => $biblio->{'itype'}, > borrowernumber => $borrowernumber, > ccode => $item->{'ccode'}} > ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9351
:
18545
|
18626
|
18627
|
18699
|
23692
|
34818
|
34819
|
34994
|
34995
|
35578
|
35712
|
35713
|
35714
|
39456
|
39457
|
39458