Attachment 35071 Details for Bug 13264 – [SIGNED OFF] Bug 13264: no need to test for MySQL

[patch] [SIGNED OFF] Bug 13264: no need to test for MySQL

SIGNED-OFF-Bug-13264-no-need-to-test-for-MySQL.patch (text/plain), 2.89 KB, created by Tomás Cohen Arazi (tcohen) on 2015-01-09 14:25:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2015-01-09 14:25:29 UTC

Size: 2.89 KB

patch

obsolete

>From d334d1333ec4dd3fc403ae9eebdf4903f182f87d Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Thu, 20 Nov 2014 12:05:24 -0300
>Subject: [PATCH] [SIGNED OFF] Bug 13264: no need to test for MySQL
>
>This patch removes the test for a running MySQL process.
>It is already implied by successfuly loading C4::Context.
>
>It also fixes the license text.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>---
> t/db_dependent/www/auth_values_input_www.t | 35 +++++++++++-------------------
> 1 file changed, 13 insertions(+), 22 deletions(-)
>
>diff --git a/t/db_dependent/www/auth_values_input_www.t b/t/db_dependent/www/auth_values_input_www.t
>index ea0f88e..4f72cc1 100644
>--- a/t/db_dependent/www/auth_values_input_www.t
>+++ b/t/db_dependent/www/auth_values_input_www.t
>@@ -1,22 +1,22 @@
> #!/usr/bin/perl
> 
>-# Copyright 2012 C & P Bibliography Services
>+# This file is part of Koha.
> #
>-# This is free software; you can redistribute it and/or modify it under the
>-# terms of the GNU General Public License as published by the Free Software
>-# Foundation; either version 2 of the License, or (at your option) any later
>-# version.
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
> #
>-# This is distributed in the hope that it will be useful, but WITHOUT ANY
>-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public License along with
>-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
>-# Suite 330, Boston, MA  02111-1307 USA
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
> #
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>+
> use utf8;
> use Test::More;
> use Test::WWW::Mechanize;
>@@ -45,13 +45,6 @@ my $user     = $ENV{KOHA_USER} || $xml->{config}->{user};
> my $password = $ENV{KOHA_PASS} || $xml->{config}->{pass};
> my $intranet = $ENV{KOHA_INTRANET_URL};
> 
>-my $mysql_on = ProgProcesses('mysql');
>-
>-
>-if ($mysql_on < 2) {
>-    plan skip_all => "Tests skip. You must start Mysql to do those tests\n";
>-}
>-
> if (not defined $intranet) {
>     plan skip_all => "Tests skip. You must set env. variable KOHA_INTRANET_URL to do tests\n";
> }
>@@ -107,6 +100,4 @@ if ($id_to_del) {
> 
> done_testing();
> 
>-sub ProgProcesses {
>-   return scalar grep /$_[0]/, (split /\n/, `ps -aef`);
>-}
>+1;
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13264: 33614 | 33703 | 33704 | 33705 | 33743 | 33744 | 33756 | 33757 | 33758 | 33759 | 33760 | 33777 | 33778 | 33779 | 33780 | 33781 | 33782 | 33783 | 33784 | 33785 | 33786 | 33811 | 33812 | 33813 | 33814 | 33815 | 33816 | 33817 | 34110 | 34111 | 34112 | 34113 | 34114 | 34115 | 34116 | 34117 | 34694 | 34766 | 34767 | 34768 | 34769 | 34770 | 34771 | 34772 | 34773 | 34774 | 34775 | 34776 | 34798 | 34799 | 34800 | 34801 | 34802 | 34803 | 34804 | 34805 | 34806 | 34807 | 34808 | 34809 | 34810 | 34811 | 34814 | 35068 | 35069 | 35070 | 35071 | 35072 | 35073 | 35074 | 35075 | 35076 | 35077 | 35078 | 35079 | 35080 | 35081 | 35082 | 35110 | 35111 | 35112 | 35113 | 35114 | 35115 | 35116 | 35117 | 35118 | 35119 | 35120 | 35121 | 35122 | 35123 | 35124