Bugzilla – Attachment 35085 Details for
Bug 13417
New permission to allow staff to remove public lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13417: (qa follow-up) Rename the permission to delete_public_lists
PASSED-QA-Bug-13417-qa-follow-up-Rename-the-permis.patch (text/plain), 3.19 KB, created by
Kyle M Hall (khall)
on 2015-01-09 14:41:09 UTC
(
hide
)
Description:
[PASSED QA] Bug 13417: (qa follow-up) Rename the permission to delete_public_lists
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-01-09 14:41:09 UTC
Size:
3.19 KB
patch
obsolete
>From c2371b9c5e08a1630ed9d380ee918ef01a5ae348 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 5 Jan 2015 10:36:33 +0100 >Subject: [PATCH] [PASSED QA] Bug 13417: (qa follow-up) Rename the permission to delete_public_lists > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/VirtualShelves.pm | 2 +- > installer/data/mysql/en/mandatory/userflags.sql | 2 +- > .../data/mysql/en/mandatory/userpermissions.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index e9815ee..284d8b1 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -471,7 +471,7 @@ sub ShelfPossibleAction { > if ( $user > 0 and $action eq 'delete_shelf' ) { > my $borrower = C4::Members::GetMember( borrowernumber => $user ); > return 1 >- if C4::Auth::haspermission( $borrower->{userid}, { shelves => 'delete_shelves' } ); >+ if C4::Auth::haspermission( $borrower->{userid}, { shelves => 'delete_public_lists' } ); > } > > my $dbh = C4::Context->dbh; >diff --git a/installer/data/mysql/en/mandatory/userflags.sql b/installer/data/mysql/en/mandatory/userflags.sql >index c027b1d..40ca2b6 100644 >--- a/installer/data/mysql/en/mandatory/userflags.sql >+++ b/installer/data/mysql/en/mandatory/userflags.sql >@@ -18,5 +18,5 @@ INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES > (17,'staffaccess','Allow staff members to modify permissions for other staff members',0), > (18,'coursereserves','Course reserves',0), > (19, 'plugins', 'Koha plugins', '0'), >-(20, 'shelves', 'Virtual shelves', 0) >+(20, 'lists', 'Lists', 0) > ; >diff --git a/installer/data/mysql/en/mandatory/userpermissions.sql b/installer/data/mysql/en/mandatory/userpermissions.sql >index a5f574f..71993dc 100644 >--- a/installer/data/mysql/en/mandatory/userpermissions.sql >+++ b/installer/data/mysql/en/mandatory/userpermissions.sql >@@ -72,5 +72,5 @@ INSERT INTO permissions (module_bit, code, description) VALUES > (19, 'tool', 'Use tool plugins'), > (19, 'report', 'Use report plugins'), > (19, 'configure', 'Configure plugins'), >- (20, 'delete_shelves', 'Delete shelves') >+ (20, 'delete_public_lists', 'Delete public lists') > ; >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index ee471a3..d3b562f 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -9660,13 +9660,13 @@ $DBversion = "3.19.00.XXX"; > if ( CheckVersion($DBversion) ) { > $dbh->do(q| > INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES >- (20, 'shelves', 'Virtual shelves', 0) >+ (20, 'lists', 'Lists', 0) > |); > $dbh->do(q| > INSERT INTO permissions (module_bit, code, description) VALUES >- (20, 'delete_shelves', 'Delete shelves') >+ (20, 'delete_public_lists', 'Delete public lists') > |); >- print "Upgrade to $DBversion done (Bug 13417: Add permission to delete shelves)\n"; >+ print "Upgrade to $DBversion done (Bug 13417: Add permission to delete public lists)\n"; > SetVersion ($DBversion); > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13417
:
34233
|
34249
|
34483
|
34485
|
34743
|
34744
|
34942
|
34943
|
35083
|
35084
|
35085
|
35086
|
35089
|
35762
|
35763
|
35764
|
35765
|
35766
|
37051