Bugzilla – Attachment 35087 Details for
Bug 13025
Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
Bug-13025---Software-error-Undefined-subroutine-C4.patch (text/plain), 3.39 KB, created by
Jonathan Druart
on 2015-01-09 14:50:49 UTC
(
hide
)
Description:
Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-01-09 14:50:49 UTC
Size:
3.39 KB
patch
obsolete
>From 48c77b3f43e2b7ea5de05e76b9246f01285e8ee6 Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Date: Thu, 8 Jan 2015 14:50:52 +0200 >Subject: [PATCH] Bug 13025 - Software error: Undefined subroutine > &C4::Circulation::HasOverdues called at > /home/koha/kohaclone/C4/Circulation.pm line 1925 > >This error only appears when using the SIPServer, it doesn't manifest when using the SIP unit tests >or when using the staff client. > >-------------------- > ------------------ > PREPARE THE TEST > ------------------ >-------------------- > >0a. Find a borrower. >0b. Find an Item (cardnumber 'debar123') and check-out to the borrower >0c. Find a borrower and add a manual debarrment to it, indefinetely in effect. > This is the default behaviour. >0d. Configure and start a SIP-server which you can access with telnet. > See http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup > In this example, the Borrower defined as the Check-out/in machine has the following credentials: > username: herkules password: palautathan branchcode: JOE_JOE > but you are free to use your own, it doesn't affect this test plan. >0e. access your server with telnet > >----------------------- > --------------------- > REPLICATE THE ISSUE > --------------------- >----------------------- >1. Paste the following SIP-command to login: >9300CNherkules|COpalautathan|CPJOE_JOE| >2. Paste the following SIP-command to check-in the Item of the debarred Borrower: >09N20140721 07501620140721 075016AP|AO|ABdebar123|AC|BIN| >3. The connection should die and in the SIP Server's error log you can find the following error: >Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 > >-------------------- > ------------------ > AFTER THIS PATCH > ------------------ >-------------------- > >Redo steps 1-2. >3. No error is given and the connection doesn't die. > >No unit tests included and never will, because setting up the test environment would be very tedious. >It is entirely possible but the scaffolding required is beyond the scope of this patch. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Note: I did not test this patch with SIP, but I did not find any >regression on checking or renewing an item. >--- > C4/Circulation.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 5cd8ba3..dd081af 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2017,7 +2017,7 @@ sub AddReturn { > if ( $borrowernumber > && $borrower->{'debarred'} > && C4::Context->preference('AutoRemoveOverduesRestrictions') >- && !HasOverdues( $borrowernumber ) >+ && !C4::Members::HasOverdues( $borrowernumber ) > && @{ GetDebarments({ borrowernumber => $borrowernumber, type => 'OVERDUES' }) } > ) { > DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' }); >@@ -2866,7 +2866,7 @@ sub AddRenewal { > my $borrower = C4::Members::GetMember( borrowernumber => $borrowernumber ); > if ( $borrowernumber > && $borrower->{'debarred'} >- && !HasOverdues( $borrowernumber ) >+ && !C4::Members::HasOverdues( $borrowernumber ) > && @{ GetDebarments({ borrowernumber => $borrowernumber, type => 'OVERDUES' }) } > ) { > DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' }); >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13025
:
35037
|
35040
| 35087