Bugzilla – Attachment 35089 Details for
Bug 13417
New permission to allow staff to remove public lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13417: Remove warnings
Bug-13417-Remove-warnings.patch (text/plain), 2.86 KB, created by
Jonathan Druart
on 2015-01-09 15:12:28 UTC
(
hide
)
Description:
Bug 13417: Remove warnings
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-01-09 15:12:28 UTC
Size:
2.86 KB
patch
obsolete
>From 2dfc460867987e508837415178ade04a05c3253a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 9 Jan 2015 16:10:11 +0100 >Subject: [PATCH] Bug 13417: Remove warnings > >Without this patch > perl -wc C4/VirtualShelves.pm >failed: >Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined >at /usr/share/perl/5.20/constant.pm line 156. >Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined at >/usr/share/perl/5.20/constant.pm line 156. >Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined at >/usr/share/perl/5.20/constant.pm line 156. >Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined at >/usr/share/perl/5.20/constant.pm line 156. >Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS >redefined at /usr/share/perl/5.20/constant.pm line 156. >Subroutine GetShelves redefined at C4/VirtualShelves.pm line 103. >Subroutine GetAllShelves redefined at C4/VirtualShelves.pm line 159. >Subroutine GetSomeShelfNames redefined at C4/VirtualShelves.pm line 189. >Subroutine GetShelf redefined at C4/VirtualShelves.pm line 230. >Subroutine GetShelfContents redefined at C4/VirtualShelves.pm line 262. >Subroutine AddShelf redefined at C4/VirtualShelves.pm line 315. >Subroutine AddToShelf redefined at C4/VirtualShelves.pm line 353. >Subroutine ModShelf redefined at C4/VirtualShelves.pm line 394. >Subroutine ShelfPossibleAction redefined at C4/VirtualShelves.pm line >454. >Subroutine DelFromShelf redefined at C4/VirtualShelves.pm line 545. >Subroutine DelShelf redefined at C4/VirtualShelves.pm line 589. >Subroutine GetBibliosShelves redefined at C4/VirtualShelves.pm line 603. >Subroutine ShelvesMax redefined at C4/VirtualShelves.pm line 628. >Subroutine HandleDelBorrower redefined at C4/VirtualShelves.pm line 648. >Subroutine AddShare redefined at C4/VirtualShelves.pm line 683. >Subroutine AcceptShare redefined at C4/VirtualShelves.pm line 703. >Subroutine IsSharedList redefined at C4/VirtualShelves.pm line 731. >Subroutine RemoveShare redefined at C4/VirtualShelves.pm line 750. >Subroutine _shelf_count redefined at C4/VirtualShelves.pm line 764. >Subroutine _CheckShelfName redefined at C4/VirtualShelves.pm line 788. >C4/VirtualShelves.pm syntax OK >--- > C4/VirtualShelves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index 284d8b1..3913c38 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -21,7 +21,6 @@ use strict; > use warnings; > > use Carp; >-use C4::Auth; > use C4::Context; > use C4::Debug; > use C4::Members; >@@ -470,6 +469,7 @@ sub ShelfPossibleAction { > > if ( $user > 0 and $action eq 'delete_shelf' ) { > my $borrower = C4::Members::GetMember( borrowernumber => $user ); >+ require C4::Auth; > return 1 > if C4::Auth::haspermission( $borrower->{userid}, { shelves => 'delete_public_lists' } ); > } >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13417
:
34233
|
34249
|
34483
|
34485
|
34743
|
34744
|
34942
|
34943
|
35083
|
35084
|
35085
|
35086
|
35089
|
35762
|
35763
|
35764
|
35765
|
35766
|
37051